From: Jakub Kicinski <kuba@kernel.org>
To: Yeounsu Moon <yyyynoom@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3 2/2] net: dlink: handle copy_thresh allocation failure
Date: Wed, 17 Sep 2025 16:09:24 -0700 [thread overview]
Message-ID: <20250917160924.6c2a5f47@kernel.org> (raw)
In-Reply-To: <20250916183305.2808-3-yyyynoom@gmail.com>
On Wed, 17 Sep 2025 03:33:05 +0900 Yeounsu Moon wrote:
> @@ -965,14 +965,11 @@ receive_packet (struct net_device *dev)
> struct sk_buff *skb;
>
> /* Small skbuffs for short packets */
> - if (pkt_len > copy_thresh) {
> - dma_unmap_single(&np->pdev->dev,
> - desc_to_dma(desc),
> - np->rx_buf_sz,
> - DMA_FROM_DEVICE);
> - skb_put(skb = np->rx_skbuff[entry], pkt_len);
> - np->rx_skbuff[entry] = NULL;
> - } else if ((skb = netdev_alloc_skb_ip_align(dev, pkt_len))) {
> + if (pkt_len <= copy_thresh) {
> + skb = netdev_alloc_skb_ip_align(dev, pkt_len);
> + if (!skb)
> + goto fallback_to_normal_path;
The goto looks pretty awkward.
skb = NULL;
if (pkt_len <= copy_thresh)
skb = netdev_alloc_skb_ip_align(dev, pkt_len);
if (!skb) {
// existing non-copy path
} else {
// existing copybreak path
}
next prev parent reply other threads:[~2025-09-17 23:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 18:33 [PATCH net v3 0/2] net: dlink: handle copy_thresh allocation Yeounsu Moon
2025-09-16 18:33 ` [PATCH net v3 1/2] net: dlink: fix whitespace around function call Yeounsu Moon
2025-09-17 23:06 ` Jakub Kicinski
2025-09-24 16:38 ` Yeounsu Moon
2025-09-24 23:12 ` Jakub Kicinski
2025-09-16 18:33 ` [PATCH net v3 2/2] net: dlink: handle copy_thresh allocation failure Yeounsu Moon
2025-09-16 19:36 ` Andrew Lunn
2025-09-17 23:09 ` Jakub Kicinski [this message]
2025-09-24 16:36 ` Yeounsu Moon
2025-09-24 23:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917160924.6c2a5f47@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yyyynoom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).