netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Bobby Eshleman <bobbyeshleman@gmail.com>
Cc: "Stefano Garzarella" <sgarzare@redhat.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"Wei Liu" <wei.liu@kernel.org>,
	"Dexuan Cui" <decui@microsoft.com>,
	"Bryan Tan" <bryan-bt.tan@broadcom.com>,
	"Vishnu Dasa" <vishnu.dasa@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	virtualization@lists.linux.dev, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, linux-hyperv@vger.kernel.org,
	berrange@redhat.com, "Bobby Eshleman" <bobbyeshleman@meta.com>
Subject: Re: [PATCH net-next v6 0/9] vsock: add namespace support to vhost-vsock
Date: Wed, 17 Sep 2025 19:40:53 +0100	[thread overview]
Message-ID: <20250917184053.GV394836@horms.kernel.org> (raw)
In-Reply-To: <aMri5apAxBpHtZbJ@devvm11784.nha0.facebook.com>

On Wed, Sep 17, 2025 at 09:33:41AM -0700, Bobby Eshleman wrote:
> On Wed, Sep 17, 2025 at 05:19:28PM +0100, Simon Horman wrote:
> > On Tue, Sep 16, 2025 at 04:43:44PM -0700, Bobby Eshleman wrote:
> > 
> > ...
> > 
> > > base-commit: 949ddfb774fe527cebfa3f769804344940f7ed2e
> > 
> > Hi Bobby,
> > 
> > This series does not seem to compile when applied to the commit above.
> > Likewise when applied to current net-next (which is now slightly newer).
> > 
> > hyperv_transport.c: In function ‘hvs_open_connection’:
> > hyperv_transport.c:316:14: error: too few arguments to function ‘vsock_find_bound_socket’
> >   316 |         sk = vsock_find_bound_socket(&addr, vsock_global_dummy_net());
> >       |              ^~~~~~~~~~~~~~~~~~~~~~~
> > In file included from hyperv_transport.c:15:
> > /home/horms/projects/linux/linux/include/net/af_vsock.h:218:14: note: declared here
> >   218 | struct sock *vsock_find_bound_socket(struct sockaddr_vm *addr, struct net *net,
> >       |              ^~~~~~~~~~~~~~~~~~~~~~~
> > 
> > -- 
> > pw-bot: changes-requested
> 
> Ah dang it, looks like I had hvc disabled when I build tested it.
> 
> Thanks for the catch, I'll fix this in the next rev.

Thanks, that would explain things.
Stuff happens :)

  reply	other threads:[~2025-09-17 18:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 23:43 [PATCH net-next v6 0/9] vsock: add namespace support to vhost-vsock Bobby Eshleman
2025-09-16 23:43 ` [PATCH net-next v6 1/9] vsock: a per-net vsock NS mode state Bobby Eshleman
2025-09-26 16:09   ` Stefano Garzarella
2025-09-16 23:43 ` [PATCH net-next v6 2/9] vsock: add net to vsock skb cb Bobby Eshleman
2025-09-26 16:15   ` Stefano Garzarella
2025-09-16 23:43 ` [PATCH net-next v6 3/9] vsock: add netns to vsock core Bobby Eshleman
2025-09-17 22:12   ` kernel test robot
2025-09-26 16:39   ` Stefano Garzarella
2025-09-16 23:43 ` [PATCH net-next v6 4/9] vsock/loopback: add netns support Bobby Eshleman
2025-09-26 15:01   ` Stefano Garzarella
2025-09-16 23:43 ` [PATCH net-next v6 5/9] vsock/virtio: add netns to virtio transport common Bobby Eshleman
2025-09-26 16:43   ` Stefano Garzarella
2025-09-16 23:43 ` [PATCH net-next v6 6/9] vhost/vsock: add netns support Bobby Eshleman
2025-09-26 16:52   ` Stefano Garzarella
2025-09-16 23:43 ` [PATCH net-next v6 7/9] selftests/vsock: improve logging in vmtest.sh Bobby Eshleman
2025-09-30  8:26   ` Stefano Garzarella
2025-09-16 23:43 ` [PATCH net-next v6 8/9] selftests/vsock: invoke vsock_test through helpers Bobby Eshleman
2025-09-30  8:37   ` Stefano Garzarella
2025-09-16 23:43 ` [PATCH net-next v6 9/9] selftests/vsock: add namespace tests Bobby Eshleman
2025-09-30  8:58   ` Stefano Garzarella
2025-10-09 16:59     ` Bobby Eshleman
2025-09-17 16:19 ` [PATCH net-next v6 0/9] vsock: add namespace support to vhost-vsock Simon Horman
2025-09-17 16:33   ` Bobby Eshleman
2025-09-17 18:40     ` Simon Horman [this message]
2025-09-26 13:52 ` Stefano Garzarella
2025-09-26 16:56   ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917184053.GV394836@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=berrange@redhat.com \
    --cc=bobbyeshleman@gmail.com \
    --cc=bobbyeshleman@meta.com \
    --cc=bryan-bt.tan@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=haiyangz@microsoft.com \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=vishnu.dasa@broadcom.com \
    --cc=wei.liu@kernel.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).