Re: [PATCH net-next] wan: framer: pef2256: use %pe in print format

[Herve Codina <herve.codina@bootlin.com>]

Hi Jakub,

On Thu, 18 Sep 2025 06:46:37 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> New cocci check complains:
> 
>   drivers/net/wan/framer/pef2256/pef2256.c:733:3-10: WARNING: Consider using %pe to print PTR_ERR()
> 
> Link: https://lore.kernel.org/1758192227-701925-1-git-send-email-tariqt@nvidia.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: herve.codina@bootlin.com
> ---
>  drivers/net/wan/framer/pef2256/pef2256.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wan/framer/pef2256/pef2256.c b/drivers/net/wan/framer/pef2256/pef2256.c
> index 1e4c8e85d598..2a25cbd3f13b 100644
> --- a/drivers/net/wan/framer/pef2256/pef2256.c
> +++ b/drivers/net/wan/framer/pef2256/pef2256.c
> @@ -719,8 +719,8 @@ static int pef2256_probe(struct platform_device *pdev)
>  	pef2256->regmap = devm_regmap_init_mmio(&pdev->dev, iomem,
>  						&pef2256_regmap_config);
>  	if (IS_ERR(pef2256->regmap)) {
> -		dev_err(&pdev->dev, "Failed to initialise Regmap (%ld)\n",
> -			PTR_ERR(pef2256->regmap));
> +		dev_err(&pdev->dev, "Failed to initialise Regmap (%pe)\n",
> +			pef2256->regmap);
>  		return PTR_ERR(pef2256->regmap);
>  	}
>  

Acked-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé