From: Jakub Kicinski <kuba@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <vladimir.oltean@nxp.com>,
<vadim.fedorenko@linux.dev>, <rmk+kernel@armlinux.org.uk>,
<christophe.jaillet@wanadoo.fr>, <rosenp@gmail.com>,
<steen.hegelund@microchip.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] phy: mscc: Fix PTP for vsc8574 and VSC8572
Date: Thu, 18 Sep 2025 16:09:42 -0700 [thread overview]
Message-ID: <20250918160942.3dc54e9a@kernel.org> (raw)
In-Reply-To: <20250917113316.3973777-1-horatiu.vultur@microchip.com>
On Wed, 17 Sep 2025 13:33:16 +0200 Horatiu Vultur wrote:
> When trying to enable PTP on vsc8574 and vsc8572 it is not working even
> if the function vsc8584_ptp_init it says that it has support for PHY
> timestamping. It is not working because there is no PTP device.
> So, to fix this make sure to create a PTP device also for this PHYs as
> they have the same PTP IP as the other vsc PHYs.
May be useful to proof read your commit message, or run it thru
a grammar checker. Copy & paste into a Google Doc would be enough..
Regarding the patch the new function looks like a spitting image
of vsc8584_probe(), minus the revision check.
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-18 23:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 11:33 [PATCH net v2] phy: mscc: Fix PTP for vsc8574 and VSC8572 Horatiu Vultur
2025-09-18 23:09 ` Jakub Kicinski [this message]
2025-09-22 12:15 ` Vladimir Oltean
2025-09-22 12:33 ` Horatiu Vultur
2025-09-22 13:28 ` Vladimir Oltean
2025-09-23 7:19 ` Horatiu Vultur
2025-09-26 7:11 ` Horatiu Vultur
2025-09-26 12:20 ` Vladimir Oltean
2025-09-26 12:21 ` Horatiu Vultur
2025-09-26 12:27 ` Vladimir Oltean
2025-09-26 12:27 ` Horatiu Vultur
2025-09-26 9:46 ` Russell King (Oracle)
2025-09-26 9:52 ` Vladimir Oltean
2025-09-26 10:19 ` Russell King (Oracle)
2025-09-26 12:12 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250918160942.3dc54e9a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rosenp@gmail.com \
--cc=steen.hegelund@microchip.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).