[PATCH net-next] net/hsr: add protocol version to fill_info output

[PATCH net-next] net/hsr: add protocol version to fill_info output

[Jan Vaclav]

Currently, it is possible to configure IFLA_HSR_VERSION, but
there is no way to check in userspace what the currently
configured HSR protocol version is.

Add it to the output of hsr_fill_info().

Signed-off-by: Jan Vaclav <jvaclav@redhat.com>
---
 net/hsr/hsr_netlink.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/hsr/hsr_netlink.c b/net/hsr/hsr_netlink.c
index b12047024..3d0bd24c6 100644
--- a/net/hsr/hsr_netlink.c
+++ b/net/hsr/hsr_netlink.c
@@ -166,6 +166,8 @@ static int hsr_fill_info(struct sk_buff *skb, const struct net_device *dev)
 		goto nla_put_failure;
 	if (hsr->prot_version == PRP_V1)
 		proto = HSR_PROTOCOL_PRP;
+	if (nla_put_u8(skb, IFLA_HSR_VERSION, hsr->prot_version))
+		goto nla_put_failure;
 	if (nla_put_u8(skb, IFLA_HSR_PROTOCOL, proto))
 		goto nla_put_failure;
 
-- 
2.51.0

Re: [PATCH net-next] net/hsr: add protocol version to fill_info output

[Simon Horman]

On Thu, Sep 18, 2025 at 02:53:38PM +0200, Jan Vaclav wrote:
> Currently, it is possible to configure IFLA_HSR_VERSION, but
> there is no way to check in userspace what the currently
> configured HSR protocol version is.
> 
> Add it to the output of hsr_fill_info().

Thanks Jan,

I agree that exposing the version to user-space makes sense
if it can be configured from user-space.

But I also think it would be useful to provide a brief example
of using this feature in the commit message. E.g. an ip command.

> 
> Signed-off-by: Jan Vaclav <jvaclav@redhat.com>

...