* [PATCH net-next] net/hsr: add protocol version to fill_info output
@ 2025-09-18 12:53 Jan Vaclav
2025-09-19 10:58 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Jan Vaclav @ 2025-09-18 12:53 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Simon Horman, netdev, Jan Vaclav
Currently, it is possible to configure IFLA_HSR_VERSION, but
there is no way to check in userspace what the currently
configured HSR protocol version is.
Add it to the output of hsr_fill_info().
Signed-off-by: Jan Vaclav <jvaclav@redhat.com>
---
net/hsr/hsr_netlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/hsr/hsr_netlink.c b/net/hsr/hsr_netlink.c
index b12047024..3d0bd24c6 100644
--- a/net/hsr/hsr_netlink.c
+++ b/net/hsr/hsr_netlink.c
@@ -166,6 +166,8 @@ static int hsr_fill_info(struct sk_buff *skb, const struct net_device *dev)
goto nla_put_failure;
if (hsr->prot_version == PRP_V1)
proto = HSR_PROTOCOL_PRP;
+ if (nla_put_u8(skb, IFLA_HSR_VERSION, hsr->prot_version))
+ goto nla_put_failure;
if (nla_put_u8(skb, IFLA_HSR_PROTOCOL, proto))
goto nla_put_failure;
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net/hsr: add protocol version to fill_info output
2025-09-18 12:53 [PATCH net-next] net/hsr: add protocol version to fill_info output Jan Vaclav
@ 2025-09-19 10:58 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2025-09-19 10:58 UTC (permalink / raw)
To: Jan Vaclav
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
On Thu, Sep 18, 2025 at 02:53:38PM +0200, Jan Vaclav wrote:
> Currently, it is possible to configure IFLA_HSR_VERSION, but
> there is no way to check in userspace what the currently
> configured HSR protocol version is.
>
> Add it to the output of hsr_fill_info().
Thanks Jan,
I agree that exposing the version to user-space makes sense
if it can be configured from user-space.
But I also think it would be useful to provide a brief example
of using this feature in the commit message. E.g. an ip command.
>
> Signed-off-by: Jan Vaclav <jvaclav@redhat.com>
...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-19 10:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-18 12:53 [PATCH net-next] net/hsr: add protocol version to fill_info output Jan Vaclav
2025-09-19 10:58 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).