From: Jakub Kicinski <kuba@kernel.org>
To: Antoine Tenart <atenart@kernel.org>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
dsahern@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/4] net: ipv4: use the right type for drop reasons in ip_rcv_finish_core
Date: Fri, 19 Sep 2025 17:37:37 -0700 [thread overview]
Message-ID: <20250919173737.7f7ce0ec@kernel.org> (raw)
In-Reply-To: <20250918083127.41147-4-atenart@kernel.org>
On Thu, 18 Sep 2025 10:31:16 +0200 Antoine Tenart wrote:
> - if (unlikely(drop_reason))
> + if (unlikely(drop_reason != SKB_NOT_DROPPED_YET))
drop_reason of none / "don't drop" is very intentionally 0 so that we
don't have to make silly comparisons of this sort. I'm applying your v1,
sorry for not paying attention earlier.
next prev parent reply other threads:[~2025-09-20 0:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 8:31 [PATCH net-next v2 0/4] net: ipv4: some drop reason cleanup and improvements Antoine Tenart
2025-09-18 8:31 ` [PATCH net-next v2 1/4] net: ipv4: make udp_v4_early_demux explicitly return drop reason Antoine Tenart
2025-09-18 8:31 ` [PATCH net-next v2 2/4] net: ipv4: simplify drop reason handling in ip_rcv_finish_core Antoine Tenart
2025-09-18 15:24 ` David Ahern
2025-09-18 17:45 ` Antoine Tenart
2025-09-18 18:42 ` David Ahern
2025-09-18 8:31 ` [PATCH net-next v2 3/4] net: ipv4: use the right type for drop reasons " Antoine Tenart
2025-09-18 18:43 ` David Ahern
2025-09-20 0:37 ` Jakub Kicinski [this message]
2025-09-18 8:31 ` [PATCH net-next v2 4/4] net: ipv4: convert ip_rcv_options to drop reasons Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919173737.7f7ce0ec@kernel.org \
--to=kuba@kernel.org \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).