netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
	Simon Horman <horms@kernel.org>,
	david decotigny <decot@googlers.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org, asantostc@gmail.com,
	efault@gmx.de, calvin@wbinvd.org, kernel-team@meta.com,
	jv@jvosburgh.net
Subject: Re: [PATCH net v5 4/4] selftest: netcons: add test for netconsole over bonded interfaces
Date: Fri, 19 Sep 2025 17:49:01 -0700	[thread overview]
Message-ID: <20250919174901.1a6062d7@kernel.org> (raw)
In-Reply-To: <20250918-netconsole_torture-v5-4-77e25e0a4eb6@debian.org>

On Thu, 18 Sep 2025 03:42:08 -0700 Breno Leitao wrote:
> This patch adds a selftest that verifies netconsole functionality
> over bonded network interfaces using netdevsim. It sets up two bonded
> interfaces acting as transmit (TX) and receive (RX) ends, placed in
> separate network namespaces. The test sends kernel log messages and
> verifies that they are properly received on the bonded RX interfaces
> with both IPv4 and IPv6, and using basic and extended netconsole
> formats.

I'm not great at reading bash but I don't think this tests what we care
about. We want to test bonding's special ability to propagate a netpoll
instances onto its sub-interfaces. So you should be trying to test
different orders of setting and disabling netpoll on the bond and its
sub-interfaces (while the other is setup path is also active).

Since the bonding tests can't run on real HW it can't live directly in
tools/testing/selftests/drivers/net/ we need to move it to either the
netdevsim group or the bonding group.

  reply	other threads:[~2025-09-20  0:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 10:42 [PATCH net v5 0/4] net: netpoll: fix memory leak and add comprehensive selftests Breno Leitao
2025-09-18 10:42 ` [PATCH net v5 1/4] net: netpoll: fix incorrect refcount handling causing incorrect cleanup Breno Leitao
2025-09-18 10:42 ` [PATCH net v5 2/4] selftest: netcons: refactor target creation Breno Leitao
2025-09-18 10:42 ` [PATCH net v5 3/4] selftest: netcons: create a torture test Breno Leitao
2025-09-18 10:42 ` [PATCH net v5 4/4] selftest: netcons: add test for netconsole over bonded interfaces Breno Leitao
2025-09-20  0:49   ` Jakub Kicinski [this message]
2025-09-26 14:06     ` Breno Leitao
2025-09-26 18:32       ` Jakub Kicinski
2025-09-29 14:50         ` Breno Leitao
2025-09-29 18:28           ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250919174901.1a6062d7@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=asantostc@gmail.com \
    --cc=calvin@wbinvd.org \
    --cc=davem@davemloft.net \
    --cc=decot@googlers.com \
    --cc=edumazet@google.com \
    --cc=efault@gmx.de \
    --cc=horms@kernel.org \
    --cc=jv@jvosburgh.net \
    --cc=kernel-team@meta.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).