From: Vincent Mailhol <mailhol@kernel.org>
To: netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
David Ahern <dsahern@gmail.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>,
linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
Vincent Mailhol <mailhol@kernel.org>
Subject: [PATCH iproute2-next 1/3] iplink_can: fix coding style for pointer format
Date: Sun, 21 Sep 2025 16:32:30 +0900 [thread overview]
Message-ID: <20250921-iplink_can-checkpatch-fixes-v1-1-1ddab98560cd@kernel.org> (raw)
In-Reply-To: <20250921-iplink_can-checkpatch-fixes-v1-0-1ddab98560cd@kernel.org>
checkpatch.pl complains about the pointer symbol * being attached to the
type instead of being attached to the variable:
ERROR: "foo* bar" should be "foo *bar"
#85: FILE: ip/iplink_can.c:85:
+ const char* name)
ERROR: "foo* bar" should be "foo *bar"
#93: FILE: ip/iplink_can.c:93:
+static void print_ctrlmode(enum output_type t, __u32 flags, const char* key)
Fix those two warnings.
Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
---
ip/iplink_can.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ip/iplink_can.c b/ip/iplink_can.c
index 9f6084e63986bd05d25a050176f4640c30596b85..1afdf08825f3d9cbbb0454592d2ed7dc1388a6de 100644
--- a/ip/iplink_can.c
+++ b/ip/iplink_can.c
@@ -82,7 +82,7 @@ static void set_ctrlmode(char *name, char *arg,
}
static void print_flag(enum output_type t, __u32 *flags, __u32 flag,
- const char* name)
+ const char *name)
{
if (*flags & flag) {
*flags &= ~flag;
@@ -90,7 +90,7 @@ static void print_flag(enum output_type t, __u32 *flags, __u32 flag,
}
}
-static void print_ctrlmode(enum output_type t, __u32 flags, const char* key)
+static void print_ctrlmode(enum output_type t, __u32 flags, const char *key)
{
if (!flags)
return;
--
2.49.1
next prev parent reply other threads:[~2025-09-21 7:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 7:32 [PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings Vincent Mailhol
2025-09-21 7:32 ` Vincent Mailhol [this message]
2025-09-22 22:10 ` [PATCH iproute2-next 1/3] iplink_can: fix coding style for pointer format Stephen Hemminger
2025-09-23 2:07 ` Vincent Mailhol
2025-09-21 7:32 ` [PATCH iproute2-next 2/3] iplink_can: fix SPDX-License-Identifier tag format Vincent Mailhol
2025-09-22 22:08 ` Stephen Hemminger
2025-09-21 7:32 ` [PATCH iproute2-next 3/3] iplink_can: factorise the calls to usage() Vincent Mailhol
2025-09-22 22:09 ` Stephen Hemminger
2025-09-22 8:42 ` [PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings Marc Kleine-Budde
2025-09-25 16:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250921-iplink_can-checkpatch-fixes-v1-1-1ddab98560cd@kernel.org \
--to=mailhol@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).