From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A95942AE99 for ; Mon, 22 Sep 2025 10:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758536160; cv=none; b=ccOmpi/fHQLKtFRUGjxIzBqkBQd9YBNmx1aJqhEicSNApuy0Ujptaz2C3NyEPDpWDNePADu0X5K7L5+2MJqkCkO9Di77fJFFFoVgtOoqJKzQla4nEsVYiKbqU8+D7zvqCfIWegbEBxlTIDpwT3SqinhniMdtI5viLF0dHQNR9M8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758536160; c=relaxed/simple; bh=ibyQSwbCJeMp5Snb2pJn2vU/VLBAJVYOPeqonV8LakE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qeE8Y9uy0hdEMcGxsSCOvmE7uQ9Q4L0bal7HBxRrjk/OxKRhFlCqmjuiySt27vFlQfPGhAQutOkNwC0dTdcYwI3hlXVbnmYbyLdlm4+1pDr4bBUW/qnPtrmBcDyDV8roM2BiKvdMb7mej4jZe0MIdK/W+AP2ZpSuuG/i9S1zjIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=YtAawqQe; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="YtAawqQe" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1758536156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=njBC5DIvqafHdOXMlLvIiK8lFeUIL7rYAYVvWpWwwvQ=; b=YtAawqQecrl/XEd1SNw+tvkRv6xvFPsEfdQlV+HxrMTGXpU6mxwe6hNjWTiEc9oyi0xxYZ 0gepBhuJRwRJta2KConbtytVJxNgonBiW2pTl3zLERP7l5tdxYKP5BP4tC1NSS9LF261W3 g1P7VW79vvcDnHVVxRXsDc5GKda51tU= From: Vadim Fedorenko To: Jakub Kicinski , Andrew Lunn , Michael Chan , Pavan Chebbi , Tariq Toukan , Gal Pressman , intel-wired-lan@lists.osuosl.org, Donald Hunter , Carolina Jubran , Aleksandr Loktionov , Vadim Fedorenko Cc: Paolo Abeni , Simon Horman , netdev@vger.kernel.org Subject: [PATCH net-next v5 0/5] add FEC bins histogram report via ethtool Date: Mon, 22 Sep 2025 10:07:36 +0000 Message-ID: <20250922100741.2167024-1-vadim.fedorenko@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT IEEE 802.3ck-2022 defines counters for FEC bins and 802.3df-2024 clarifies it a bit further. Implement reporting interface through as addition to FEC stats available in ethtool. NetDevSim driver has simple implementation as an example while mlx5 has much more complex solution. The example query is the same as usual FEC statistics while the answer is a bit more verbose: [vmuser@archvm9 linux]$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/ethtool.yaml --do fec-get --json '{"header":{"dev-index": 10, "flags": 4}}' {'auto': 0, 'header': {'dev-index': 10, 'dev-name': 'eni10np1'}, 'modes': {'bits': {}, 'nomask': True, 'size': 121}, 'stats': {'corr-bits': [], 'corrected': [123], 'hist': [{'bin-high': 0, 'bin-low': 0, 'bin-val': 445, 'bin-val-per-lane': [125, 120, 100, 100]}, {'bin-high': 3, 'bin-low': 1, 'bin-val': 12}, {'bin-high': 7, 'bin-low': 4, 'bin-val': 2, 'bin-val-per-lane': [2, 0, 0, 0]}], 'uncorr': [4]}} v4 -> v5: * fix selftests error path v3 -> v4: * update spec to avoid using underscores * make core accumulate per-lane errors into bin error counter * adjust wording in Documentation * improve FEC type check in mlx5 * add selftest to do sanity check of reported histogram * partially carry-over Rb tags from Aleksandr because of logical changes v3 Link - https://lore.kernel.org/netdev/20250916191257.13343-1-vadim.fedorenko@linux.dev/ v2 -> v3: * fix yaml spec to use binary array for histogram per-lane values * fix spelling v1 -> v2: * fix memset size of FEC histogram bins in mlx5 * adjust fbnic driver FEC stats callback Links to RFC discussions: v1 - https://lore.kernel.org/netdev/20250729102354.771859-1-vadfed@meta.com/ v2 - https://lore.kernel.org/netdev/20250731231019.1809172-1-vadfed@meta.com/ v3 - https://lore.kernel.org/netdev/20250802063024.2423022-1-vadfed@meta.com/ v4 - https://lore.kernel.org/netdev/20250807155924.2272507-1-vadfed@meta.com/ v5 - https://lore.kernel.org/netdev/20250815132729.2251597-1-vadfed@meta.com/ Carolina Jubran (3): net/mlx5e: Don't query FEC statistics when FEC is disabled net/mlx5e: Add logic to read RS-FEC histogram bin ranges from PPHCR net/mlx5e: Report RS-FEC histogram statistics via ethtool Vadim Fedorenko (2): ethtool: add FEC bins histogram report selftests: net-drv: stats: sanity check FEC histogram Documentation/netlink/specs/ethtool.yaml | 26 ++++ Documentation/networking/ethtool-netlink.rst | 5 + .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 +- .../ethernet/fungible/funeth/funeth_ethtool.c | 3 +- .../ethernet/hisilicon/hns3/hns3_ethtool.c | 3 +- drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 +- .../marvell/octeontx2/nic/otx2_ethtool.c | 3 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 + .../ethernet/mellanox/mlx5/core/en_ethtool.c | 5 +- .../net/ethernet/mellanox/mlx5/core/en_main.c | 8 ++ .../ethernet/mellanox/mlx5/core/en_stats.c | 125 +++++++++++++++++- .../ethernet/mellanox/mlx5/core/en_stats.h | 3 +- .../net/ethernet/meta/fbnic/fbnic_ethtool.c | 3 +- drivers/net/ethernet/sfc/ethtool.c | 3 +- drivers/net/ethernet/sfc/siena/ethtool.c | 3 +- drivers/net/netdevsim/ethtool.c | 25 +++- include/linux/ethtool.h | 25 +++- .../uapi/linux/ethtool_netlink_generated.h | 11 ++ net/ethtool/fec.c | 75 ++++++++++- tools/testing/selftests/drivers/net/stats.py | 35 ++++- 20 files changed, 345 insertions(+), 24 deletions(-) -- 2.47.3