From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de,
"Stefan Mätje" <stefan.maetje@esd.eu>
Subject: Re: [PATCH net 08/10] can: esd_usb: Fix not detecting version reply in probe routine
Date: Mon, 22 Sep 2025 17:16:26 -0700 [thread overview]
Message-ID: <20250922171626.2ebb1e30@kernel.org> (raw)
In-Reply-To: <20250922100913.392916-9-mkl@pengutronix.de>
On Mon, 22 Sep 2025 12:07:38 +0200 Marc Kleine-Budde wrote:
> + do {
> + int actual_length;
> + int pos;
> +
> + err = usb_bulk_msg(dev->udev,
> + usb_rcvbulkpipe(dev->udev, 1),
> + rx_buf,
> + ESD_USB_RX_BUFFER_SIZE,
> + &actual_length,
> + ESD_USB_DRAIN_TIMEOUT_MS);
> + dev_dbg(&dev->udev->dev, "AT %d, LEN %d, ERR %d\n", attempt, actual_length, err);
> + ++attempt;
> + if (err)
> + goto bail;
> + if (actual_length == 0)
> + continue;
continue in do-while loops doesn't check the condition.
This looks like a potential infinite loop?
next prev parent reply other threads:[~2025-09-23 0:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 10:07 [PATCH net 0/10] pull-request: can 2025-09-22 Marc Kleine-Budde
2025-09-22 10:07 ` [PATCH net 01/10] can: hi311x: fix null pointer dereference when resuming from sleep before interface was enabled Marc Kleine-Budde
2025-09-22 10:07 ` [PATCH net 02/10] can: rcar_canfd: Fix controller mode setting Marc Kleine-Budde
2025-09-22 10:07 ` [PATCH net 03/10] can: etas_es58x: populate ndo_change_mtu() to prevent buffer overflow Marc Kleine-Budde
2025-09-22 10:07 ` [PATCH net 04/10] can: hi311x: " Marc Kleine-Budde
2025-09-22 10:07 ` [PATCH net 05/10] can: sun4i_can: " Marc Kleine-Budde
2025-09-22 10:07 ` [PATCH net 06/10] can: mcba_usb: " Marc Kleine-Budde
2025-09-22 10:07 ` [PATCH net 07/10] can: peak_usb: fix shift-out-of-bounds issue Marc Kleine-Budde
2025-09-22 10:07 ` [PATCH net 08/10] can: esd_usb: Fix not detecting version reply in probe routine Marc Kleine-Budde
2025-09-23 0:16 ` Jakub Kicinski [this message]
2025-09-24 10:05 ` Stefan Mätje
2025-09-22 10:07 ` [PATCH net 09/10] can: esd_usb: Fix handling of TX context objects Marc Kleine-Budde
2025-09-23 0:17 ` Jakub Kicinski
2025-09-24 13:26 ` Stefan Mätje
2025-09-24 14:12 ` Marc Kleine-Budde
2025-09-22 10:07 ` [PATCH net 10/10] can: esd_usb: Add watermark handling for TX jobs Marc Kleine-Budde
2025-09-23 0:19 ` [PATCH net 0/10] pull-request: can 2025-09-22 Jakub Kicinski
2025-09-23 7:56 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922171626.2ebb1e30@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=stefan.maetje@esd.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).