Re: [PATCH net-next v2 1/6] bnxt_en: Move common definitions to include/linux/bnxt/

[Jonathan Cameron <jonathan.cameron@huawei.com>]

On Tue, 23 Sep 2025 02:58:20 -0700
Pavan Chebbi <pavan.chebbi@broadcom.com> wrote:

> We have common definitions that are now going to be used
> by more than one component outside of bnxt (bnxt_re and
> fwctl)
> 
> Move bnxt_ulp.h to include/linux/bnxt/ as ulp.h.
> Have a new common.h, also at the same place that will
> have some non-ulp but shared bnxt declarations.
> 
> Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
> Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
One really minor comment inline. Given this does exactly what you say
FWIW.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

> diff --git a/include/linux/bnxt/common.h b/include/linux/bnxt/common.h
> new file mode 100644
> index 000000000000..2ee75a0a1feb
> --- /dev/null
> +++ b/include/linux/bnxt/common.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> +/*
> + * Copyright (c) 2025, Broadcom Corporation
> + *

Totally trivial but this blank line adds nothing useful.

> + */
> +
> +#ifndef BNXT_COMN_H
> +#define BNXT_COMN_H
> +
> +#include <linux/bnxt/hsi.h>
> +#include <linux/bnxt/ulp.h>
> +#include <linux/auxiliary_bus.h>
> +
> +struct bnxt_aux_priv {
> +	struct auxiliary_device aux_dev;
> +	struct bnxt_en_dev *edev;
> +	int id;
> +};
> +
> +#endif /* BNXT_COMN_H */
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h b/include/linux/bnxt/ulp.h
> similarity index 100%
> rename from drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h
> rename to include/linux/bnxt/ulp.h