From: Jakub Kicinski <kuba@kernel.org>
To: Jan Vaclav <jvaclav@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net/hsr: add protocol version to fill_info output
Date: Tue, 23 Sep 2025 17:06:04 -0700 [thread overview]
Message-ID: <20250923170604.6c629d90@kernel.org> (raw)
In-Reply-To: <20250922093743.1347351-3-jvaclav@redhat.com>
On Mon, 22 Sep 2025 11:37:45 +0200 Jan Vaclav wrote:
> if (hsr->prot_version == PRP_V1)
> proto = HSR_PROTOCOL_PRP;
> + if (nla_put_u8(skb, IFLA_HSR_VERSION, hsr->prot_version))
> + goto nla_put_failure;
Looks like configuration path does not allow setting version if proto
is PRP. Should we add an else before the if? since previous if is
checking for PRP already
next prev parent reply other threads:[~2025-09-24 0:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 9:37 [PATCH v2 net-next] net/hsr: add protocol version to fill_info output Jan Vaclav
2025-09-23 7:22 ` Simon Horman
2025-09-24 0:06 ` Jakub Kicinski [this message]
2025-09-24 11:21 ` Ján Václav
2025-09-24 12:01 ` Fernando Fernandez Mancera
2025-09-24 23:40 ` Jakub Kicinski
2025-09-25 8:37 ` Fernando Fernandez Mancera
2025-09-26 2:00 ` Jakub Kicinski
2025-09-26 9:33 ` Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923170604.6c629d90@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jvaclav@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).