Re: [PATCH net-next v13 1/5] net: rnpgbe: Add build support for rnpgbe

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 22 Sep 2025 09:41:07 +0800 Dong Yibo wrote:
> +===========================================================
> +Linux Base Driver for MUCSE(R) Gigabit PCI Express Adapters
> +===========================================================
> +
> +MUCSE Gigabit Linux driver.

You already said that in the heading above

> +Copyright (c) 2020 - 2025 MUCSE Co.,Ltd.

copyright is metadata, it should not be part of the user-visible doc.

> +Identifying Your Adapter
> +========================
> +The driver is compatible with devices based on the following:
> +
> + * MUCSE(R) Ethernet Controller N500 series
> + * MUCSE(R) Ethernet Controller N210 series

These are out of numeric sort order

> +Support
> +=======
> + If you have problems with the software or hardware, please contact our
> + customer support team via email at techsupport@mucse.com or check our
> + website at https://www.mucse.com/en/

Please don't add support statements. People can use a search engine if
they want to find the corporate support. The kernel docs are for kernel
topics, and "support" in the kernel is done on the mailing list.


> +config MGBE
> +	tristate "Mucse(R) 1GbE PCI Express adapters support"
> +	depends on PCI
> +	select PAGE_POOL

you're not using page pool in this series

> +MODULE_DEVICE_TABLE(pci, rnpgbe_pci_tbl);
> +MODULE_AUTHOR("Mucse Corporation, <techsupport@mucse.com>");

Only humans can author code, not corporations. Delete his AUTHOR entry
or add yourself as the author.

> +MODULE_DESCRIPTION("Mucse(R) 1 Gigabit PCI Express Network Driver");
> +MODULE_LICENSE("GPL");