From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: Deepak Sharma <deepak.sharma.472935@gmail.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
pwn9uin@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+07b635b9c111c566af8b@syzkaller.appspotmail.com
Subject: Re: [PATCH] Fix the cleanup on alloc_mpc failure in atm_mpoa_mpoad_attach
Date: Wed, 24 Sep 2025 16:45:01 -0700 [thread overview]
Message-ID: <20250924164501.23f6e708@kernel.org> (raw)
In-Reply-To: <20250924184451.GT836419@horms.kernel.org>
On Wed, 24 Sep 2025 19:44:51 +0100 Simon Horman wrote:
> The preferred coding style is:
>
> if (mpc == NULL) {
Or better still:
if (!mpc)
we tend to avoid comparisons to zero and NULL.
next prev parent reply other threads:[~2025-09-24 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 13:24 [PATCH] Fix the cleanup on alloc_mpc failure in atm_mpoa_mpoad_attach Deepak Sharma
2025-09-24 18:41 ` Simon Horman
2025-09-24 18:44 ` Simon Horman
2025-09-24 23:45 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-09-25 20:40 Deepak Sharma
2025-09-28 15:26 ` David Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250924164501.23f6e708@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=deepak.sharma.472935@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pwn9uin@gmail.com \
--cc=syzbot+07b635b9c111c566af8b@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).