From: Jakub Kicinski <kuba@kernel.org>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: Amery Hung <ameryhung@gmail.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: pull-request: bpf-next 2025-09-23
Date: Wed, 24 Sep 2025 17:29:24 -0700 [thread overview]
Message-ID: <20250924172924.72c85b24@kernel.org> (raw)
In-Reply-To: <35282ea2-7ccb-450a-aa78-491f2e84cbf3@linux.dev>
On Wed, 24 Sep 2025 17:09:52 -0700 Martin KaFai Lau wrote:
> On 9/24/25 3:18 PM, Jakub Kicinski wrote:
> > 74: (15) if r1 == 0x20 goto pc+309 384: frame1: R0=map_value(map=map_xdp_setup,ks=4,vs=4) R1=32 R2=0xfffffeff R3=scalar(smin=0xffffffff80000000,smax=0x7fffffff) R4=16 R5=1 R6=2 R7=ctx() R8=pkt(off=34,r=42) R9=scalar() R10=fp0 fp-336=mmmmmmmm
> > ; switch (*val) { @ xdp_native.bpf.c:594
> > 384: (b7) r4 = 32 ; frame1: R4_w=32
> > 385: (05) goto pc+1
> > 387: (7b) *(u64 *)(r10 -352) = r5 ; frame1: R5=1 R10=fp0 fp-352_w=1
> > 388: (1f) r8 -= r9
>
> The "hdr_len = (void *)udph_ptr - data + sizeof(struct udphdr);" calculation
> needs to reload the ctx->data after filter_udphdr(). Amery will send a fix.
Phew! no compiler update needed :) Thank you!
prev parent reply other threads:[~2025-09-25 0:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 5:03 pull-request: bpf-next 2025-09-23 Martin KaFai Lau
2025-09-24 17:30 ` patchwork-bot+netdevbpf
2025-09-24 22:18 ` Jakub Kicinski
2025-09-25 0:09 ` Martin KaFai Lau
2025-09-25 0:29 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250924172924.72c85b24@kernel.org \
--to=kuba@kernel.org \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).