From: Jakub Kicinski <kuba@kernel.org>
To: Yangfl <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Simon Horman <horms@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v11 5/5] net: dsa: yt921x: Add support for Motorcomm YT921x
Date: Wed, 24 Sep 2025 17:35:51 -0700 [thread overview]
Message-ID: <20250924173551.2e09b168@kernel.org> (raw)
In-Reply-To: <CAAXyoMNBHgG-DFv16ua-T__iBXg=chFQ6TNoXdZvk4VP2aYESA@mail.gmail.com>
On Wed, 24 Sep 2025 20:33:57 +0800 Yangfl wrote:
> On Wed, Sep 24, 2025 at 8:47 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > > + cancel_delayed_work_sync(&pp->mib_read);
> > > + }
> > > +
> > > + dsa_unregister_switch(&priv->ds);
> >
> > The work canceling looks racy, the port can come up in between
> > cancel_work and dsa_unregister ? disable_delayed_work.. will likely
> > do the job.
>
> Are you sure about this? There are many others who use
> cancel_delayed_work_sync in their teardown methods (for example
> ar9331_sw_remove). If that is true, they should be fixed too.
Not at all! I'll gladly accept an explanation of why the code is
correct. "Someone else is doing it too" is not an explanation.
prev parent reply other threads:[~2025-09-25 0:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 13:11 [PATCH net-next v11 0/5] net: dsa: yt921x: Add support for Motorcomm YT921x David Yang
2025-09-22 13:11 ` [PATCH net-next v11 1/5] dt-bindings: ethernet-phy: add reverse SGMII phy interface type David Yang
2025-09-23 13:46 ` Rob Herring (Arm)
2025-09-22 13:11 ` [PATCH net-next v11 2/5] net: phy: introduce PHY_INTERFACE_MODE_REVSGMII David Yang
2025-09-23 14:32 ` Maxime Chevallier
2025-09-24 17:50 ` Russell King (Oracle)
2025-09-24 18:41 ` Andrew Lunn
2025-09-24 19:18 ` Russell King (Oracle)
2025-09-26 6:30 ` Yangfl
2025-09-26 8:45 ` Russell King (Oracle)
2025-09-26 16:09 ` Andrew Lunn
2025-09-26 16:28 ` Yangfl
2025-09-26 18:06 ` Russell King (Oracle)
2025-09-22 13:11 ` [PATCH net-next v11 3/5] dt-bindings: net: dsa: yt921x: Add Motorcomm YT921x switch support David Yang
2025-09-22 13:11 ` [PATCH net-next v11 4/5] net: dsa: tag_yt921x: add support for Motorcomm YT921x tags David Yang
2025-09-22 13:11 ` [PATCH net-next v11 5/5] net: dsa: yt921x: Add support for Motorcomm YT921x David Yang
2025-09-24 0:47 ` Jakub Kicinski
2025-09-24 12:33 ` Yangfl
2025-09-25 0:35 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250924173551.2e09b168@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).