From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>
Subject: Re: [PATCH net-next v5 4/4] net: libwx: restrict change user-set RSS configuration
Date: Wed, 24 Sep 2025 18:34:56 -0700 [thread overview]
Message-ID: <20250924183456.5508ee95@kernel.org> (raw)
In-Reply-To: <20250922094327.26092-5-jiawenwu@trustnetic.com>
On Mon, 22 Sep 2025 17:43:27 +0800 Jiawen Wu wrote:
> --- a/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> @@ -472,6 +472,12 @@ int wx_set_channels(struct net_device *dev,
> if (count > wx_max_channels(wx))
> return -EINVAL;
>
> + if (netif_is_rxfh_configured(wx->netdev)) {
> + wx_err(wx, "Cannot change channels while RXFH is configured\n");
> + wx_err(wx, "Run 'ethtool -X <if> default' to reset RSS table\n");
> + return -EBUSY;
> + }
Why the check in set_channels? Kernel already rejects attempts to
decrease queue count below what's configured in the indir table.
If table is set you should be able to change the ring count, just
don't override the table.
next prev parent reply other threads:[~2025-09-25 1:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 9:43 [PATCH net-next v5 0/4] net: wangxun: support to configure RSS Jiawen Wu
2025-09-22 9:43 ` [PATCH net-next v5 1/4] net: libwx: support separate RSS configuration for every pool Jiawen Wu
2025-09-25 1:30 ` Jakub Kicinski
2025-09-22 9:43 ` [PATCH net-next v5 2/4] net: libwx: move rss_field to struct wx Jiawen Wu
2025-09-22 9:43 ` [PATCH net-next v5 3/4] net: wangxun: add RSS reta and rxfh fields support Jiawen Wu
2025-09-22 9:43 ` [PATCH net-next v5 4/4] net: libwx: restrict change user-set RSS configuration Jiawen Wu
2025-09-25 1:34 ` Jakub Kicinski [this message]
2025-09-25 1:36 ` [PATCH net-next v5 0/4] net: wangxun: support to configure RSS Jakub Kicinski
2025-09-25 7:28 ` Jiawen Wu
2025-09-26 2:04 ` Jakub Kicinski
2025-09-26 2:21 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250924183456.5508ee95@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).