netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Kommula Shiva Shankar <kshankar@marvell.com>,
	netdev@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
	pabeni@redhat.com, xuanzhuo@linux.alibaba.com
Cc: oe-kbuild-all@lists.linux.dev, virtualization@lists.linux.dev,
	parav@nvidia.com, jerinj@marvell.com, ndabilpuram@marvell.com,
	sburla@marvell.com, schalla@marvell.com
Subject: Re: [PATCH v1 net-next  2/3] virtio_net: enable outer nw header offset support.
Date: Thu, 25 Sep 2025 09:07:18 +0800	[thread overview]
Message-ID: <202509250856.HoVMjFzw-lkp@intel.com> (raw)
In-Reply-To: <20250923202258.2738717-3-kshankar@marvell.com>

Hi Kommula,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Kommula-Shiva-Shankar/net-implement-virtio-helper-to-handle-outer-nw-offset/20250924-042602
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250923202258.2738717-3-kshankar%40marvell.com
patch subject: [PATCH v1 net-next  2/3] virtio_net: enable outer nw header offset support.
config: x86_64-randconfig-122-20250924 (https://download.01.org/0day-ci/archive/20250925/202509250856.HoVMjFzw-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250925/202509250856.HoVMjFzw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509250856.HoVMjFzw-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   drivers/net/virtio_net.c: note: in included file:
>> include/linux/virtio_net.h:389:72: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted __virtio16 [usertype] val @@     got restricted __le16 [usertype] outer_nh_offset @@
   include/linux/virtio_net.h:389:72: sparse:     expected restricted __virtio16 [usertype] val
   include/linux/virtio_net.h:389:72: sparse:     got restricted __le16 [usertype] outer_nh_offset
>> include/linux/virtio_net.h:411:39: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] outer_nh_offset @@     got restricted __virtio16 @@
   include/linux/virtio_net.h:411:39: sparse:     expected restricted __le16 [usertype] outer_nh_offset
   include/linux/virtio_net.h:411:39: sparse:     got restricted __virtio16

vim +389 include/linux/virtio_net.h

a2fb4bc4e2a6a0 Paolo Abeni           2025-07-08  376  
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  377  static inline int
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  378  virtio_net_out_net_header_to_skb(struct sk_buff *skb,
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  379  				 struct virtio_net_hdr_v1_hash_tunnel_out_net_hdr *vhdr,
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  380  				 bool out_net_hdr_negotiated,
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  381  				 bool little_endian)
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  382  {
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  383  	unsigned int out_net_hdr_off;
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  384  
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  385  	if (!out_net_hdr_negotiated)
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  386  		return 0;
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  387  
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  388  	if (vhdr->outer_nh_offset) {
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24 @389  		out_net_hdr_off = __virtio16_to_cpu(little_endian, vhdr->outer_nh_offset);
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  390  		skb_set_network_header(skb, out_net_hdr_off);
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  391  	}
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  392  
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  393  	return 0;
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  394  }
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  395  
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  396  static inline int
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  397  virtio_net_out_net_header_from_skb(const struct sk_buff *skb,
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  398  				   struct virtio_net_hdr_v1_hash_tunnel_out_net_hdr *vhdr,
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  399  				   bool out_net_hdr_negotiated,
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  400  				   bool little_endian)
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  401  {
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  402  	unsigned int out_net_hdr_off;
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  403  
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  404  	if (!out_net_hdr_negotiated) {
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  405  		vhdr->outer_nh_offset = 0;
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  406  		return 0;
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  407  	}
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  408  
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  409  	out_net_hdr_off = skb_network_offset(skb);
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  410  	if (out_net_hdr_off && skb->protocol == htons(ETH_P_IP))
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24 @411  		vhdr->outer_nh_offset = __cpu_to_virtio16(little_endian,
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  412  							  out_net_hdr_off);
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  413  
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  414  	return 0;
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  415  }
1dc49efaeaa4c1 Kommula Shiva Shankar 2025-09-24  416  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-09-25  1:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23 20:22 [PATCH v1 net-next 0/3] virtio_net: Implement VIRTIO_NET_F_OUT_NET_HEADER from virtio spec 1.4 Kommula Shiva Shankar
2025-09-23 20:22 ` [PATCH v1 net-next 1/3] net: implement virtio helper to handle outer nw offset Kommula Shiva Shankar
2025-09-24  0:51   ` Jason Wang
2025-09-24  1:11     ` Jason Wang
2025-10-03 11:06       ` [EXTERNAL] " Shiva Shankar Kommula
2025-09-23 20:22 ` [PATCH v1 net-next 2/3] virtio_net: enable outer nw header offset support Kommula Shiva Shankar
2025-09-25  1:07   ` kernel test robot [this message]
2025-09-23 20:22 ` [PATCH v1 net-next 3/3] vhost/net: " Kommula Shiva Shankar
2025-09-24 15:44   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202509250856.HoVMjFzw-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jasowang@redhat.com \
    --cc=jerinj@marvell.com \
    --cc=kshankar@marvell.com \
    --cc=mst@redhat.com \
    --cc=ndabilpuram@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=parav@nvidia.com \
    --cc=sburla@marvell.com \
    --cc=schalla@marvell.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).