From: Simon Horman <horms@kernel.org>
To: Mengyuan Lou <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com,
duanqiangwen@net-swift.com, linglingzhang@trustnetic.com
Subject: Re: [PATCH net-next] Wangxun: vf: Implement some ethtool apis for get_xxx
Date: Thu, 25 Sep 2025 10:22:16 +0100 [thread overview]
Message-ID: <20250925092216.GA836419@horms.kernel.org> (raw)
In-Reply-To: <20250924082140.41612-1-mengyuanlou@net-swift.com>
On Wed, Sep 24, 2025 at 04:21:40PM +0800, Mengyuan Lou wrote:
> Implement some ethtool interfaces for obtaining the status of
> Wangxun Virtual Function Ethernet.
> Just like connection status, version information, queue depth and so on.
>
> Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>
Hi Mengyuan Lou,
To my mind this patch, although small is doing quite a few things.
1. Adding ethtool code to libwx
2. Using 1 in two drivers
3. Adding a wx_get_fw_version_vf() call to two drivers
To be honest I would probably have split this up a bit.
Especially 3. But perhaps that is just me.
Also, I think that, as things stand, "net: wangxun: " would be a more
appropriate prefix for the title of the patch.
So if you do decide to re-spin, please consider the above.
But regardless, the code looks fine to me.
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2025-09-25 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 8:21 [PATCH net-next] Wangxun: vf: Implement some ethtool apis for get_xxx Mengyuan Lou
2025-09-25 9:22 ` Simon Horman [this message]
2025-09-27 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925092216.GA836419@horms.kernel.org \
--to=horms@kernel.org \
--cc=duanqiangwen@net-swift.com \
--cc=jiawenwu@trustnetic.com \
--cc=linglingzhang@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).