From: Simon Horman <horms@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kernel-team@meta.com, kuba@kernel.org, pabeni@redhat.com,
vadim.fedorenko@linux.dev
Subject: Re: [PATCH net-next] eth: fbnic: Add support to read lane count
Date: Thu, 25 Sep 2025 11:16:42 +0100 [thread overview]
Message-ID: <20250925101642.GD836419@horms.kernel.org> (raw)
In-Reply-To: <20250924184445.2293325-1-mohsin.bashr@gmail.com>
On Wed, Sep 24, 2025 at 11:44:45AM -0700, Mohsin Bashir wrote:
> We are reporting the lane count in the link settings but the flag is not
> set to indicate that the driver supports lanes. Set the flag to report
> lane count.
>
> ~]# ethtool eth0 | grep Lanes
> Lanes: 2
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
It's not not entirely clear to me why Jakub's tag is here.
> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
I agree this i correct because linkmodes_prepare_data()
will zero the lanes value, after retrieving it from the driver,
unless cap_link_lanes_supported is set.
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2025-09-25 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 18:44 [PATCH net-next] eth: fbnic: Add support to read lane count Mohsin Bashir
2025-09-25 10:16 ` Simon Horman [this message]
2025-09-26 21:10 ` Jakub Kicinski
2025-09-27 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925101642.GD836419@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).