From: "Michael S. Tsirkin" <mst@redhat.com>
To: Dan Jurgens <danielj@nvidia.com>
Cc: netdev@vger.kernel.org, jasowang@redhat.com,
alex.williamson@redhat.com, pabeni@redhat.com,
virtualization@lists.linux.dev, parav@nvidia.com,
shshitrit@nvidia.com, yohadt@nvidia.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
shameerali.kolothum.thodi@huawei.com, jgg@ziepe.ca,
kevin.tian@intel.com, kuba@kernel.org, andrew+netdev@lunn.ch,
edumazet@google.com
Subject: Re: [PATCH net-next v3 08/11] virtio_net: Implement IPv4 ethtool flow rules
Date: Thu, 25 Sep 2025 17:20:49 -0400 [thread overview]
Message-ID: <20250925171936-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5518ba7f-80b4-43f1-a5c1-eb8298170e9a@nvidia.com>
On Thu, Sep 25, 2025 at 04:13:42PM -0500, Dan Jurgens wrote:
> On 9/25/25 3:53 PM, Michael S. Tsirkin wrote:
> > On Tue, Sep 23, 2025 at 09:19:17AM -0500, Daniel Jurgens wrote:
> >> Add support for IP_USER type rules from ethtool.
> >>
> >> +static
> >> +struct virtio_net_ff_selector *next_selector(struct virtio_net_ff_selector *sel)
> >> +{
> >> + void *nextsel;
> >> +
> >> + nextsel = (u8 *)sel + sizeof(struct virtio_net_ff_selector) +
> >> + sel->length;
> >
> > you do not need this variable. and cast to void* looks cleaner imho.
>
> It's cast to u8* so we do pointer arithmetic in bytes, which is not
> standard C on void*. GCC doesn't mind, but I thing Clang does.
>
> I saw you had a similar comment on a subsequent too.>
it's a known C standard bug.
kernel does void* math everywhere.
Linus hath spoken on this ;)
> >> +
> >> + return nextsel;
> >> +}
> >> +
>
next prev parent reply other threads:[~2025-09-25 21:20 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 14:19 [PATCH net-next v3 00/11] virtio_net: Add ethtool flow rules support Daniel Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 01/11] virtio-pci: Expose generic device capability operations Daniel Jurgens
2025-09-24 1:16 ` Jason Wang
2025-09-24 6:22 ` Michael S. Tsirkin
2025-09-24 19:02 ` Dan Jurgens
2025-09-25 6:16 ` Michael S. Tsirkin
2025-09-25 9:51 ` Parav Pandit
2025-09-25 10:35 ` Michael S. Tsirkin
2025-09-25 10:45 ` Parav Pandit
2025-09-25 11:49 ` Michael S. Tsirkin
2025-09-25 12:09 ` Parav Pandit
2025-09-25 13:08 ` Michael S. Tsirkin
2025-09-25 16:53 ` Dan Jurgens
2025-09-25 16:55 ` Michael S. Tsirkin
2025-09-26 4:55 ` Jason Wang
2025-09-26 14:26 ` Michael S. Tsirkin
2025-09-26 15:08 ` Dan Jurgens
2025-09-24 6:16 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 02/11] virtio-pci: Expose object create and destroy API Daniel Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 03/11] virtio_net: Create virtio_net directory Daniel Jurgens
2025-09-25 3:56 ` Xuan Zhuo
2025-09-25 6:13 ` Michael S. Tsirkin
2025-09-25 15:48 ` Dan Jurgens
2025-09-25 20:10 ` Michael S. Tsirkin
2025-09-25 21:17 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 04/11] virtio_net: Query and set flow filter caps Daniel Jurgens
2025-09-25 21:01 ` Michael S. Tsirkin
2025-09-26 2:12 ` Dan Jurgens
2025-09-27 9:02 ` Michael S. Tsirkin
2025-09-25 21:16 ` Michael S. Tsirkin
2025-09-26 4:54 ` Dan Jurgens
2025-09-26 16:01 ` Simon Horman
2025-09-26 18:08 ` Dan Jurgens
2025-09-26 20:45 ` Jakub Kicinski
2025-09-23 14:19 ` [PATCH net-next v3 05/11] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2025-09-25 21:13 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 06/11] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2025-09-25 20:58 ` Michael S. Tsirkin
2025-09-27 4:45 ` Dan Jurgens
2025-09-25 21:10 ` Michael S. Tsirkin
2025-09-27 5:02 ` Dan Jurgens
2025-09-26 20:48 ` Jakub Kicinski
2025-09-26 21:04 ` Dan Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 07/11] virtio_net: Use existing classifier if possible Daniel Jurgens
2025-09-25 20:53 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 08/11] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2025-09-25 20:53 ` Michael S. Tsirkin
2025-09-25 21:13 ` Dan Jurgens
2025-09-25 21:20 ` Michael S. Tsirkin [this message]
2025-10-01 14:15 ` Dan Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 09/11] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2025-09-25 20:47 ` Michael S. Tsirkin
2025-09-23 14:19 ` [PATCH net-next v3 10/11] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2025-09-23 14:19 ` [PATCH net-next v3 11/11] virtio_net: Add get ethtool flow rules ops Daniel Jurgens
2025-09-25 20:44 ` Michael S. Tsirkin
2025-09-28 4:39 ` Dan Jurgens
2025-09-28 6:19 ` Michael S. Tsirkin
2025-09-25 21:19 ` [PATCH net-next v3 00/11] virtio_net: Add ethtool flow rules support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925171936-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=danielj@nvidia.com \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shshitrit@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yohadt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).