From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04B335971; Fri, 26 Sep 2025 20:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758919707; cv=none; b=Wk3yFluddeqIKhwl8e7mcSr+JZATYyevWVpakEu637XJU1DkGrt5IFAnXQKmiyKjVyAEyhUc3VMP2tVNZ6nVJjKC3iN4ILBd14UXikZqhN/jP37QGIVl6Ox2bASRWTjbirDWWjagqS3buL+gEJhcKKn63wrkzcnKizNprW+hmP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758919707; c=relaxed/simple; bh=BUVGQoH2N0WsNEAKZIM1gsCNHToYThnB7HqMBH0JPpI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aW6PbebLSf5wV5e3Z06o34p3XWrhI4WwU2wmldnyMAoLzuXQGdPlIAu/IXqBcYjyFTOqxgr+p4J54QFcKGAS+6yIeR1Vl3ISjzlZGNMjtTJYW+jCmnAtImkSFcRMREsA3qnpCrmtbJnxxGPWo5+bPDQsa1QvZakmputIcyrmJtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AmpDTnPp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AmpDTnPp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C006DC4CEF4; Fri, 26 Sep 2025 20:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758919706; bh=BUVGQoH2N0WsNEAKZIM1gsCNHToYThnB7HqMBH0JPpI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AmpDTnPpmKVuZJLlrszCArpdBHew6QYLaJPiQQXNAFS3yVFrb6IaCd5oevs1iTU9b QlSdShemBcQYuJJjgCNOT/4wNMnngOWGvHZ9Tltd5oOk2sXRQsi3JNKOpd019mzSZF C8UBlKdeCt3YccteHv71iXBDiM1Aaq0sXX8ZKbqal4hQEDWkYyklETcGYP6P1rZ0xG 6N/q+LqI9r4CBVIquarzGxNClc50ty6JVO7puTJP8kbqLos7BTBDNnovZLXDCWQwl7 8dJFYA3V+Sb64WJ9NH3TTa455mXU51QIwW0EVhtWiWQayQGq4PCS8UEyiN/4Hmhsbr fXz2LqMCHLqTQ== Date: Fri, 26 Sep 2025 13:48:24 -0700 From: Jakub Kicinski To: Daniel Jurgens Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v3 06/11] virtio_net: Implement layer 2 ethtool flow rules Message-ID: <20250926134824.6d0dc043@kernel.org> In-Reply-To: <20250923141920.283862-7-danielj@nvidia.com> References: <20250923141920.283862-1-danielj@nvidia.com> <20250923141920.283862-7-danielj@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 23 Sep 2025 09:19:15 -0500 Daniel Jurgens wrote: > Filtering a flow requires a classifier to match the packets, and a rule > to filter on the matches. > > A classifier consists of one or more selectors. There is one selector > per header type. A selector must only use fields set in the selector > capabality. If partial matching is supported, the classifier mask for a > particular field can be a subset of the mask for that field in the > capability. > > The rule consists of a priority, an action and a key. The key is a byte > array containing headers corresponding to the selectors in the > classifier. > > This patch implements ethtool rules for ethernet headers. What does the spec say about ordering of the rules? If the rules are not evaluated in an equivalent way to a linear walk / match please support location == RX_CLS_LOC_ANY only