[PATCH net-next] eth: fbnic: Add support to read lane count

[PATCH net-next] eth: fbnic: Add support to read lane count

[Mohsin Bashir]

We are reporting the lane count in the link settings but the flag is not
set to indicate that the driver supports lanes. Set the flag to report
lane count.

 ~]# ethtool eth0 | grep Lanes
	Lanes: 2

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
---
 drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c b/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c
index b4ff98ee2051..f60a2338765c 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c
@@ -1804,6 +1804,7 @@ fbnic_get_rmon_stats(struct net_device *netdev,
 }
 
 static const struct ethtool_ops fbnic_ethtool_ops = {
+	.cap_link_lanes_supported	= true,
 	.supported_coalesce_params	= ETHTOOL_COALESCE_USECS |
 					  ETHTOOL_COALESCE_RX_MAX_FRAMES,
 	.supported_ring_params		= ETHTOOL_RING_USE_TCP_DATA_SPLIT |
-- 
2.47.3

Re: [PATCH net-next] eth: fbnic: Add support to read lane count

[Simon Horman]

On Wed, Sep 24, 2025 at 11:44:45AM -0700, Mohsin Bashir wrote:
> We are reporting the lane count in the link settings but the flag is not
> set to indicate that the driver supports lanes. Set the flag to report
> lane count.
> 
>  ~]# ethtool eth0 | grep Lanes
> 	Lanes: 2
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

It's not not entirely clear to me why Jakub's tag is here.

> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>

I agree this i correct because linkmodes_prepare_data()
will zero the lanes value, after retrieving it from the driver,
unless cap_link_lanes_supported is set.

Reviewed-by: Simon Horman <horms@kernel.org>

...

Re: [PATCH net-next] eth: fbnic: Add support to read lane count

[Jakub Kicinski]

On Thu, 25 Sep 2025 11:16:42 +0100 Simon Horman wrote:
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>  
> 
> It's not not entirely clear to me why Jakub's tag is here.

Internal review FWIW. Since reviews than internally don't count
for much upstream I opted for using SoB. Probably also wrong but shrug.

Re: [PATCH net-next] eth: fbnic: Add support to read lane count

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 24 Sep 2025 11:44:45 -0700 you wrote:
> We are reporting the lane count in the link settings but the flag is not
> set to indicate that the driver supports lanes. Set the flag to report
> lane count.
> 
>  ~]# ethtool eth0 | grep Lanes
> 	Lanes: 2
> 
> [...]

Here is the summary with links:
  - [net-next] eth: fbnic: Add support to read lane count
    https://git.kernel.org/netdev/net-next/c/20a2e46f9e4c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html