From: Eric Biggers <ebiggers@kernel.org>
To: netdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Cc: bpf@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH iproute2-next] lib/bpf_legacy: Use userspace SHA-1 code instead of AF_ALG
Date: Sat, 27 Sep 2025 11:36:41 -0700 [thread overview]
Message-ID: <20250927183641.GA1719@quark> (raw)
In-Reply-To: <20250925225322.13013-1-ebiggers@kernel.org>
On Thu, Sep 25, 2025 at 03:53:22PM -0700, Eric Biggers wrote:
> ctx->obj_fd = open(pathname, O_RDONLY);
> - if (ctx->obj_fd < 0)
> + if (ctx->obj_fd < 0) {
> + fprintf(stderr, "Error opening object %s: %s\n", pathname,
> + strerror(errno));
> return ctx->obj_fd;
> + }
> +
> + ret = bpf_obj_hash(ctx->obj_fd, pathname, tmp);
> + if (ret)
> + return ret;
Correction: the 'return ret;' above should be 'goto out_fd;'.
I'll fix this in v2, but I'll wait a bit for more feedback first.
- Eric
next prev parent reply other threads:[~2025-09-27 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 22:53 [PATCH iproute2-next] lib/bpf_legacy: Use userspace SHA-1 code instead of AF_ALG Eric Biggers
2025-09-27 18:36 ` Eric Biggers [this message]
2025-09-28 13:51 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250927183641.GA1719@quark \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).