From: Jakub Kicinski <kuba@kernel.org>
To: Octavian Purdila <tavip@google.com>
Cc: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me,
ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
toke@redhat.com, lorenzo@kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org,
syzbot+ff145014d6b0ce64a173@syzkaller.appspotmail.com,
Kuniyuki Iwashima <kuniyu@google.com>
Subject: Re: [PATCH net] xdp: use multi-buff only if receive queue supports page pool
Date: Tue, 30 Sep 2025 10:41:29 -0700 [thread overview]
Message-ID: <20250930104129.20a2aa7e@kernel.org> (raw)
In-Reply-To: <CAGWr4cSwEbuSPEJp6=-8gRbD7O-pOqzn_1fXPxWv-ZX3b7NX_w@mail.gmail.com>
On Mon, 29 Sep 2025 17:01:49 -0700 Octavian Purdila wrote:
> local_lock_nested_bh(&system_page_pool.bh_lock);
> - err = skb_cow_data_for_xdp(this_cpu_read(system_page_pool.pool), pskb, prog);
> + pool = this_cpu_read(system_page_pool.pool);
> + err = skb_cow_data_for_xdp(pool, pskb, prog);
> + rxq->mem.type = MEM_TYPE_PAGE_POOL;
> + rxq->mem.id = pool->xdp_mem_id;
> local_unlock_nested_bh(&system_page_pool.bh_lock);
Yes, LGTM. I _think_ that only skb_cow_data_for_xdp() has to be under
the lock here, but doesn't really matter.
prev parent reply other threads:[~2025-09-30 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 6:08 [PATCH net] xdp: use multi-buff only if receive queue supports page pool Octavian Purdila
2025-09-25 0:09 ` Jakub Kicinski
2025-09-25 7:53 ` Octavian Purdila
2025-09-25 9:42 ` Maciej Fijalkowski
2025-09-26 2:12 ` Jakub Kicinski
2025-09-26 7:33 ` Octavian Purdila
2025-09-26 11:24 ` Maciej Fijalkowski
2025-09-26 19:40 ` Jakub Kicinski
2025-09-30 0:01 ` Octavian Purdila
2025-09-30 17:41 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930104129.20a2aa7e@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuniyu@google.com \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=syzbot+ff145014d6b0ce64a173@syzkaller.appspotmail.com \
--cc=tavip@google.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).