From: Jakub Kicinski <kuba@kernel.org>
To: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
Cc: Thangaraj.S@microchip.com, Rengarajan.S@microchip.com,
UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
o.rempel@pengutronix.de, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+62ec8226f01cb4ca19d9@syzkaller.appspotmail.com
Subject: Re: [PATCH] net: usb: lan78xx: Fix lost EEPROM read timeout error(-ETIMEDOUT) in lan78xx_read_raw_eeprom
Date: Tue, 30 Sep 2025 17:39:50 -0700 [thread overview]
Message-ID: <20250930173950.5d7636e2@kernel.org> (raw)
In-Reply-To: <20250930084902.19062-1-bhanuseshukumar@gmail.com>
On Tue, 30 Sep 2025 14:19:02 +0530 Bhanu Seshu Kumar Valluri wrote:
> + if (dev->chipid == ID_REV_CHIP_ID_7800_) {
> + int rc = lan78xx_write_reg(dev, HW_CFG, saved);
> + /* If USB fails, there is nothing to do */
> + if (rc < 0)
> + return rc;
> + }
> + return ret;
I don't think you need to add and handle rc here separately?
rc can only be <= so save the answer to ret and "fall thru"?
--
pw-bot: cr
next prev parent reply other threads:[~2025-10-01 0:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 8:49 [PATCH] net: usb: lan78xx: Fix lost EEPROM read timeout error(-ETIMEDOUT) in lan78xx_read_raw_eeprom Bhanu Seshu Kumar Valluri
2025-10-01 0:39 ` Jakub Kicinski [this message]
2025-10-01 4:37 ` Bhanu Seshu Kumar Valluri
2025-10-01 7:42 ` Oleksij Rempel
2025-10-01 8:10 ` Bhanu Seshu Kumar Valluri
2025-10-01 8:24 ` Oleksij Rempel
2025-10-01 8:31 ` Bhanu Seshu Kumar Valluri
2025-10-01 8:38 ` Oleksij Rempel
2025-10-01 8:45 ` Bhanu Seshu Kumar Valluri
2025-10-01 8:51 ` Oleksij Rempel
2025-10-03 18:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930173950.5d7636e2@kernel.org \
--to=kuba@kernel.org \
--cc=Rengarajan.S@microchip.com \
--cc=Thangaraj.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhanuseshukumar@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=syzbot+62ec8226f01cb4ca19d9@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).