From: Jakub Kicinski <kuba@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: Octavian Purdila <tavip@google.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <horms@kernel.org>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <sdf@fomichev.me>,
<kuniyu@google.com>, <aleksander.lobakin@intel.com>,
<toke@redhat.com>, <lorenzo@kernel.org>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>,
<syzbot+ff145014d6b0ce64a173@syzkaller.appspotmail.com>
Subject: Re: [PATCH net v2] xdp: update mem type when page pool is used for generic XDP
Date: Wed, 1 Oct 2025 08:27:37 -0700 [thread overview]
Message-ID: <20251001082737.23f5037f@kernel.org> (raw)
In-Reply-To: <aN091c4VZRtZwZDZ@boxer>
On Wed, 1 Oct 2025 16:42:29 +0200 Maciej Fijalkowski wrote:
> Here we piggy back on sk_buff::pp_recycle setting as it implies underlying
> memory is backed by page pool.
skb->pp_recycle means that if the pages of the skb came from a pp then
the skb is holding a pp reference not a full page reference on those
pages. It does not mean that all pages of an skb came from pp.
In practice it may be equivalent, especially here. But I'm slightly
worried that checking pp_recycle will lead to confusion..
next prev parent reply other threads:[~2025-10-01 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 7:47 [PATCH net v2] xdp: update mem type when page pool is used for generic XDP Octavian Purdila
2025-10-01 14:42 ` Maciej Fijalkowski
2025-10-01 15:27 ` Jakub Kicinski [this message]
2025-10-01 19:06 ` Maciej Fijalkowski
2025-10-02 1:15 ` Octavian Purdila
2025-10-02 12:54 ` Maciej Fijalkowski
2025-10-02 16:57 ` Octavian Purdila
2025-10-01 20:26 ` Ihor Solodrai
2025-10-02 1:02 ` Octavian Purdila
2025-10-02 18:32 ` Ihor Solodrai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251001082737.23f5037f@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuniyu@google.com \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=syzbot+ff145014d6b0ce64a173@syzkaller.appspotmail.com \
--cc=tavip@google.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).