From: Jakub Kicinski <kuba@kernel.org>
To: Kriish Sharma <kriish.sharma2006@gmail.com>
Cc: khalasa@piap.pl, khc@pm.waw.pl, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] hdlc_ppp: fix potential null pointer in ppp_cp_event logging
Date: Fri, 3 Oct 2025 09:17:29 -0700 [thread overview]
Message-ID: <20251003091729.3158a8db@kernel.org> (raw)
In-Reply-To: <20251003092918.1428164-1-kriish.sharma2006@gmail.com>
On Fri, 3 Oct 2025 09:29:18 +0000 Kriish Sharma wrote:
> Fixes: 262858079afd ("Add linux-next specific files for 20250926")
This is not a fix, please post the next version in 2 weeks
(after the merge window has closed) and without the Fixes tag.
The warning (not so?) obviously doesn't apply to the kernel.
Kernel print methods will output "(null)" if you pass 0 as
the value to %s.
I defer to Krzysztof on whether we should proceed with this
patch as a cleanup, but -Wformat-overflow= is disabled in
the kernel builds for a good reason. This is not a fix.
--
pw-bot: cr
prev parent reply other threads:[~2025-10-03 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 9:29 [PATCH net v2] hdlc_ppp: fix potential null pointer in ppp_cp_event logging Kriish Sharma
2025-10-03 10:03 ` Simon Horman
2025-10-03 10:09 ` Kriish Sharma
2025-10-03 12:33 ` Krzysztof Hałasa
2025-10-03 13:45 ` Kriish Sharma
2025-10-03 16:17 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251003091729.3158a8db@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=khalasa@piap.pl \
--cc=khc@pm.waw.pl \
--cc=kriish.sharma2006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).