From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, bpf@vger.kernel.org,
alexanderduyck@fb.com, sdf@fomichev.me, mohsin.bashr@gmail.com
Subject: Re: [PATCH net 2/9] eth: fbnic: fix accounting of XDP packets
Date: Sat, 4 Oct 2025 17:45:08 +0100 [thread overview]
Message-ID: <20251004164508.GG3060232@horms.kernel.org> (raw)
In-Reply-To: <20251003233025.1157158-3-kuba@kernel.org>
On Fri, Oct 03, 2025 at 04:30:18PM -0700, Jakub Kicinski wrote:
> Make XDP-handled packets appear in the Rx stats. The driver has been
> counting XDP_TX packets on the Tx ring, but there wasn't much accounting
> on the Rx side (the Rx bytes appear to be incremented on XDP_TX but
> XDP_DROP / XDP_ABORT are only counted as Rx drops).
>
> Counting XDP_TX packets (not just bytes) in Rx stats looks like
> a simple bug of omission.
>
> The XDP_DROP handling appears to be intentional. Whether XDP_DROP
> packets should be counted in interface-level Rx stats is a bit
> unclear historically. When we were defining qstats, however,
> we clarified based on operational experience that in this context:
>
> name: rx-packets
> doc: |
> Number of wire packets successfully received and passed to the stack.
> For drivers supporting XDP, XDP is considered the first layer
> of the stack, so packets consumed by XDP are still counted here.
>
> fbnic does not obey this requirement. Since XDP support has been added
> in current release cycle, instead of splitting interface and qstat
> handling - make them both follow the qstat definition.
>
> Another small tweak here is that we count bytes as received on the wire
> rather than post-XDP bytes (xdp_get_buff_len() vs skb->len).
>
> Fixes: 5213ff086344 ("eth: fbnic: Collect packet statistics for XDP")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-10-04 16:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 23:30 [PATCH net 0/9] eth: fbnic: fix XDP_TX and XDP vs qstats Jakub Kicinski
2025-10-03 23:30 ` [PATCH net 1/9] eth: fbnic: fix missing programming of the default descriptor Jakub Kicinski
2025-10-04 16:44 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 2/9] eth: fbnic: fix accounting of XDP packets Jakub Kicinski
2025-10-04 16:45 ` Simon Horman [this message]
2025-10-03 23:30 ` [PATCH net 3/9] eth: fbnic: fix saving stats from XDP_TX rings on close Jakub Kicinski
2025-10-04 16:45 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 4/9] selftests: drv-net: xdp: rename netnl to ethnl Jakub Kicinski
2025-10-04 16:46 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 5/9] selftests: drv-net: xdp: add test for interface level qstats Jakub Kicinski
2025-10-04 16:47 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 6/9] eth: fbnic: fix reporting of alloc_failed qstats Jakub Kicinski
2025-10-04 16:48 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 7/9] selftests: drv-net: fix linter warnings in pp_alloc_fail Jakub Kicinski
2025-10-04 16:48 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 8/9] selftests: drv-net: pp_alloc_fail: lower traffic expectations Jakub Kicinski
2025-10-04 16:44 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 9/9] selftests: drv-net: pp_alloc_fail: add necessary optoins to config Jakub Kicinski
2025-10-04 16:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251004164508.GG3060232@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).