* [PATCH] net/mlx5: fix pre-2.40 binutils assembler error
@ 2025-10-06 11:56 Arnd Bergmann
2025-10-06 18:21 ` Jakub Kicinski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Arnd Bergmann @ 2025-10-06 11:56 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Mark Bloch,
Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Patrisious Haddad, Moshe Shemesh, Michael Guralnik
Cc: Arnd Bergmann, Naresh Kamboju, Nathan Chancellor, Simon Horman,
Cosmin Ratiu, Yishai Hadas, Maor Gottlieb, netdev, linux-rdma,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Old binutils versions require a slightly stricter syntax for the .arch_extension
directive and fail with the extra semicolon:
/tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'
Drop the semicolon to make it work with all supported toolchain version.
Link: https://lore.kernel.org/all/20251001163655.GA370262@ax162/
Reported-by: Paolo Abeni <pabeni@redhat.com>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Suggested-by: Nathan Chancellor <nathan@kernel.org>
Fixes: fd8c8216648c ("net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/mellanox/mlx5/core/wc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wc.c b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
index c281153bd411..05e5fd777d4f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/wc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
@@ -266,7 +266,7 @@ static void mlx5_iowrite64_copy(struct mlx5_wc_sq *sq, __be32 mmio_wqe[16],
if (cpu_has_neon()) {
kernel_neon_begin();
asm volatile
- (".arch_extension simd;\n\t"
+ (".arch_extension simd\n\t"
"ld1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%0]\n\t"
"st1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%1]"
:
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net/mlx5: fix pre-2.40 binutils assembler error
2025-10-06 11:56 [PATCH] net/mlx5: fix pre-2.40 binutils assembler error Arnd Bergmann
@ 2025-10-06 18:21 ` Jakub Kicinski
2025-10-07 17:12 ` Patrisious Haddad
2025-10-06 19:08 ` Nathan Chancellor
2025-10-08 1:50 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2025-10-06 18:21 UTC (permalink / raw)
To: Saeed Mahameed
Cc: Arnd Bergmann, Leon Romanovsky, Tariq Toukan, Mark Bloch,
Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
Patrisious Haddad, Moshe Shemesh, Michael Guralnik, Arnd Bergmann,
Naresh Kamboju, Nathan Chancellor, Simon Horman, Cosmin Ratiu,
Yishai Hadas, Maor Gottlieb, netdev, linux-rdma, linux-kernel
On Mon, 6 Oct 2025 13:56:34 +0200 Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Old binutils versions require a slightly stricter syntax for the .arch_extension
> directive and fail with the extra semicolon:
>
> /tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'
>
> Drop the semicolon to make it work with all supported toolchain version.
Saeed, could you ack? I think we should get this merged quickly since
it's a build fix.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/mlx5: fix pre-2.40 binutils assembler error
2025-10-06 18:21 ` Jakub Kicinski
@ 2025-10-07 17:12 ` Patrisious Haddad
0 siblings, 0 replies; 5+ messages in thread
From: Patrisious Haddad @ 2025-10-07 17:12 UTC (permalink / raw)
To: Jakub Kicinski, Saeed Mahameed
Cc: Arnd Bergmann, Leon Romanovsky, Tariq Toukan, Mark Bloch,
Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
Moshe Shemesh, Michael Guralnik, Arnd Bergmann, Naresh Kamboju,
Nathan Chancellor, Simon Horman, Cosmin Ratiu, Yishai Hadas,
Maor Gottlieb, netdev, linux-rdma, linux-kernel
Thanks Arnd
On 10/6/2025 9:21 PM, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, 6 Oct 2025 13:56:34 +0200 Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Old binutils versions require a slightly stricter syntax for the .arch_extension
>> directive and fail with the extra semicolon:
>>
>> /tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'
>>
>> Drop the semicolon to make it work with all supported toolchain version.
Reviewed-by: Patrisious Haddad <phaddad@nvidia.com>
> Saeed, could you ack? I think we should get this merged quickly since
> it's a build fix.
If my ack is enough you can merge, was planning to send this fix myself.
Thanks,
Patrisious.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/mlx5: fix pre-2.40 binutils assembler error
2025-10-06 11:56 [PATCH] net/mlx5: fix pre-2.40 binutils assembler error Arnd Bergmann
2025-10-06 18:21 ` Jakub Kicinski
@ 2025-10-06 19:08 ` Nathan Chancellor
2025-10-08 1:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: Nathan Chancellor @ 2025-10-06 19:08 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Mark Bloch,
Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Patrisious Haddad, Moshe Shemesh, Michael Guralnik,
Arnd Bergmann, Naresh Kamboju, Simon Horman, Cosmin Ratiu,
Yishai Hadas, Maor Gottlieb, netdev, linux-rdma, linux-kernel
On Mon, Oct 06, 2025 at 01:56:34PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Old binutils versions require a slightly stricter syntax for the .arch_extension
> directive and fail with the extra semicolon:
>
> /tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'
>
> Drop the semicolon to make it work with all supported toolchain version.
>
> Link: https://lore.kernel.org/all/20251001163655.GA370262@ax162/
> Reported-by: Paolo Abeni <pabeni@redhat.com>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Suggested-by: Nathan Chancellor <nathan@kernel.org>
> Fixes: fd8c8216648c ("net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/wc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wc.c b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
> index c281153bd411..05e5fd777d4f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/wc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
> @@ -266,7 +266,7 @@ static void mlx5_iowrite64_copy(struct mlx5_wc_sq *sq, __be32 mmio_wqe[16],
> if (cpu_has_neon()) {
> kernel_neon_begin();
> asm volatile
> - (".arch_extension simd;\n\t"
> + (".arch_extension simd\n\t"
> "ld1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%0]\n\t"
> "st1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%1]"
> :
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net/mlx5: fix pre-2.40 binutils assembler error
2025-10-06 11:56 [PATCH] net/mlx5: fix pre-2.40 binutils assembler error Arnd Bergmann
2025-10-06 18:21 ` Jakub Kicinski
2025-10-06 19:08 ` Nathan Chancellor
@ 2025-10-08 1:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-08 1:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: saeedm, leon, tariqt, mbloch, andrew+netdev, davem, edumazet,
kuba, pabeni, phaddad, moshe, michaelgur, arnd, naresh.kamboju,
nathan, horms, cratiu, yishaih, maorg, netdev, linux-rdma,
linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 6 Oct 2025 13:56:34 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Old binutils versions require a slightly stricter syntax for the .arch_extension
> directive and fail with the extra semicolon:
>
> /tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'
>
> [...]
Here is the summary with links:
- net/mlx5: fix pre-2.40 binutils assembler error
https://git.kernel.org/netdev/net/c/e475fa420e6c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-08 1:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-06 11:56 [PATCH] net/mlx5: fix pre-2.40 binutils assembler error Arnd Bergmann
2025-10-06 18:21 ` Jakub Kicinski
2025-10-07 17:12 ` Patrisious Haddad
2025-10-06 19:08 ` Nathan Chancellor
2025-10-08 1:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).