From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 201002BEC2A; Wed, 8 Oct 2025 20:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759955017; cv=none; b=FFrNK63E2c7p0s47op47tkwla1ANI2egcRg2hrKe9jrva3mlc7tShn3v7JZKkYHV62S0qfgw16+Oa9Q3n2MezGjJ908/UX5ZSJxSs4eU1xZts+v3RJZfUowU0fexmazshRgRam5Ms8X7eKB3EMTwSKn/MHNNVwJf48h3EEy5K3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759955017; c=relaxed/simple; bh=DbK+CIg0XXjUCRkiskVCTpZVzWdUCTlE60U/2rfFy0o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rKVr8r1xzbIl2aLL5KvlX/3WIL9SwzeogcnzzK8aHMIkZxle4NVNhW/3qOmK4Stxr9v8XZ57uT0n9/Bw9jTWnE/SJrbVa65Vx3g/pmIN/OJXWtbUyh3jytmtQ1UqqnDy6WbIzZf8CJZeTX71zgKgKWf11ecVi5Xj/ehQUmGh0zw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oTHT9X76; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oTHT9X76" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1D8BC4CEFE; Wed, 8 Oct 2025 20:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759955016; bh=DbK+CIg0XXjUCRkiskVCTpZVzWdUCTlE60U/2rfFy0o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=oTHT9X76cEeII2tEVVMWAT+2rO5xi6YHHPq9Eydy3ZCDa4qVmksLmDvl8486+FnNV AnCWLBG5fOnYlP7IJyBtZPiy966uW8VjvV2/QdqWguuNqyO5exauiDczTacOP60nrK kbN0mxFs/kdkKRO7oiNLy3I1158yiYZWrhrWVGxXyeOo6/socYLXcz0XZmI/VUiT5V /k/QqyxJVUwVjbMgnlS/wEVofpJxH6G06Vl2o6qkWjprYkMOUqJS7O0sysSVIdXXCl WUIUHfYjVn5e6ktS9XMiIPKcSaILbpwjZTdzEQ29OK5AsUYIMJoyxrAFcFoJer8RST 8kyt/31btaTtg== From: Jeff Layton Date: Wed, 08 Oct 2025 16:23:28 -0400 Subject: [PATCH v2 1/2] sunrpc: account for TCP record marker in rq_bvec array when sending Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251008-rq_bvec-v2-1-823c0a85a27c@kernel.org> References: <20251008-rq_bvec-v2-0-823c0a85a27c@kernel.org> In-Reply-To: <20251008-rq_bvec-v2-0-823c0a85a27c@kernel.org> To: Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Howells Cc: Brandon Adams , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1048; i=jlayton@kernel.org; h=from:subject:message-id; bh=DbK+CIg0XXjUCRkiskVCTpZVzWdUCTlE60U/2rfFy0o=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBo5shDX6GT/JmQu56eH4kinOofpyhD3+CDIQkzs OWJAm5UR5CJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaObIQwAKCRAADmhBGVaC FUx3EACDRJsuZ23+W9ApX2TAYYdhU7PR/hqUx1loUf4d0E8imprxFRHEWJGzO8CtcwCKxsfb+8c rD+d7neAm41g2TG9AFCvvrOyIYWx2HWbgEj355RiTM+4IeQ2DLM+u9EyXaJG2X8ICgIj27knqwP 0CtqCuF8XE+x5QJ1pfMnn93eeY0dg5sDb6genU/anG0T4OItAidWyEW1Lc9RPmApgMMLOcdd4Iv oS2x4lCP10CCwH9pc8gYUM6YyzE6WjXMluKp1g8mBwEiagpe2YYA58KG9T038eaf6c9VIig1p9f ygh3g3pyg65qY7MSZZazMl8t0SnPRImOc81vSy7y2DhmmetkKR3STVmaDh4ky8wdWvXidlBqNRo 3pfhuUti3wshnf7BZ/nBYCF2CnLsDxbsdoiX8S4Bk/t67dNSIEO2IQ1EedYxHj2tYDbKnTVvZow RO9SLpk0IfU7AP/+QeSQrYo5N2+HpM5NFUwOoeGc3Y/2FCrJqWhRjUK0xL3iYIF3mSa3/RN/WKr Ava96GVA0SX4t/7mC9nOxt6Nr09/qDwrXn1rbw+xETHUP5yV3gP1Egb36GrQtAGKBRZZoqW1uwa RQeTwWFYWMSk7ClC10NSUxV0d5wLOfHmjIX0aRVe00hX50+e8ENKck8kifIIOqY1nBGLfI70pcL TUn3U8ARaGi5N9Q== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 The call to xdr_buf_to_bvec() in svc_tcp_sendto() passes in the second slot to the bvec array as the starting slot, but doesn't decrease the length of the array by one. Fixes: 59cf7346542b ("sunrpc: Replace the rq_bvec array with dynamically-allocated memory") Signed-off-by: Jeff Layton --- net/sunrpc/svcsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 7b90abc5cf0ee1520796b2f38fcb977417009830..377fcaaaa061463fc5c85fc09c7a8eab5e06af77 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c @@ -1244,7 +1244,7 @@ static int svc_tcp_sendmsg(struct svc_sock *svsk, struct svc_rqst *rqstp, memcpy(buf, &marker, sizeof(marker)); bvec_set_virt(rqstp->rq_bvec, buf, sizeof(marker)); - count = xdr_buf_to_bvec(rqstp->rq_bvec + 1, rqstp->rq_maxpages, + count = xdr_buf_to_bvec(rqstp->rq_bvec + 1, rqstp->rq_maxpages - 1, &rqstp->rq_res); iov_iter_bvec(&msg.msg_iter, ITER_SOURCE, rqstp->rq_bvec, -- 2.51.0