netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kommula Shiva Shankar <kshankar@marvell.com>
Cc: netdev@vger.kernel.org, jasowang@redhat.com, pabeni@redhat.com,
	xuanzhuo@linux.alibaba.com, virtualization@lists.linux.dev,
	parav@nvidia.com, jerinj@marvell.com, ndabilpuram@marvell.com,
	sburla@marvell.com, schalla@marvell.com
Subject: Re: [PATCH v2 net-next  3/3] vhost/net: enable outer nw header offset support
Date: Thu, 9 Oct 2025 06:31:00 -0400	[thread overview]
Message-ID: <20251009062720-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20251008110004.2933101-4-kshankar@marvell.com>

On Wed, Oct 08, 2025 at 04:30:04PM +0530, Kommula Shiva Shankar wrote:
> apprise vhost net about the virtio net header size.
> 
> Signed-off-by: Kommula Shiva Shankar <kshankar@marvell.com>
> ---
>  drivers/vhost/net.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index 35ded4330431..8d055405746d 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -78,6 +78,7 @@ static const u64 vhost_net_features[VIRTIO_FEATURES_DWORDS] = {
>  	(1ULL << VIRTIO_F_IN_ORDER),
>  	VIRTIO_BIT(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO) |
>  	VIRTIO_BIT(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO),
> +	VIRTIO_BIT(VIRTIO_NET_F_OUT_NET_HEADER),
>  };
>  
>  enum {


How does this even work?
VIRTIO_FEATURES_DWORDS is 2, you can't really
add more elements.

Pls include info on testing done in your next
submission.


> @@ -1655,6 +1656,9 @@ static int vhost_net_set_features(struct vhost_net *n, const u64 *features)
>  		  sizeof(struct virtio_net_hdr_mrg_rxbuf) :
>  		  sizeof(struct virtio_net_hdr);
>  
> +	if (virtio_features_test_bit(features,
> +				     VIRTIO_NET_F_OUT_NET_HEADER))
> +		hdr_len = sizeof(struct virtio_net_hdr_v1_hash_tunnel_out_net_hdr);
>  	if (virtio_features_test_bit(features,
>  				     VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO) ||
>  	    virtio_features_test_bit(features,
> -- 
> 2.48.1


  parent reply	other threads:[~2025-10-09 10:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 11:00 [PATCH v2 net-next 0/3] virtio_net: Implement VIRTIO_NET_F_OUT_NET_HEADER from virtio spec 1.4 Kommula Shiva Shankar
2025-10-08 11:00 ` [PATCH v2 net-next 1/3] net: implement virtio helper to handle outer nw offset Kommula Shiva Shankar
2025-10-08 11:00 ` [PATCH v2 net-next 2/3] virtio_net: enable outer nw header offset support Kommula Shiva Shankar
2025-10-08 11:00 ` [PATCH v2 net-next 3/3] vhost/net: " Kommula Shiva Shankar
2025-10-09  9:44   ` Paolo Abeni
2025-10-09 10:31   ` Michael S. Tsirkin [this message]
2025-10-08 11:26 ` [PATCH v2 net-next 0/3] virtio_net: Implement VIRTIO_NET_F_OUT_NET_HEADER from virtio spec 1.4 Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251009062720-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jerinj@marvell.com \
    --cc=kshankar@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=parav@nvidia.com \
    --cc=sburla@marvell.com \
    --cc=schalla@marvell.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).