From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF7672D321A for ; Thu, 9 Oct 2025 12:54:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760014466; cv=none; b=DmucNDVhVTRxvm3RqhxPP/NSxKOUvjPCwzh0/0Zatf+I9xbvCw0U30gbaqeMfDI4x3V4KIv7XQPzEBgDAzIuBXQ03UA8u5sdeYX89DUVvgvk6/01RrJiw6PALPMhsKYt7kVv6NzfnW3sf0bEv5kUTcgaHP8uTICqjf2U8VWt3LI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760014466; c=relaxed/simple; bh=d+WHqjD1e2xfxGWREFy8UIQh97c1/2BfHbOxP9RKa5g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PJ+A+U9OcM+4TpqHFFgIygTceXCkl9Ke9xUy+zzlEWLY50mr5TqcHOKyH47Lw1H/jG3uTTn5ompiuobtchCm5bSB348PY0z+m2Tzjrz3pJOujzOJR0VDqT6vywZg4bY2SKp96jhAgAI4c09ZxKKx1R4rsvixSO41q6ssSPs1n0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EmD0KM70; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EmD0KM70" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760014464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sLVQWh+Znqw6JAYRNwQHXL1TFNSvZ0jniZ0MloD7+Hg=; b=EmD0KM70H+qEk6u1/odi44dhRuJ0K//SKUto1pWqhyzf2GbFFVJmOcA8n6hUqUnRG6J3QU V66IpEO7gxhbE/i6C5sVV7N2ypZ3zouB0z9/KPZJgawI7PqZe+yQy/OwGtLxTN2i6OM0NW IXwE7TQyw4TJTlhVRtezBhSW0uiMgHA= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-7V1ffcNePDacd3s0KWqZog-1; Thu, 09 Oct 2025 08:54:23 -0400 X-MC-Unique: 7V1ffcNePDacd3s0KWqZog-1 X-Mimecast-MFC-AGG-ID: 7V1ffcNePDacd3s0KWqZog_1760014462 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-856c1aa079bso353702785a.0 for ; Thu, 09 Oct 2025 05:54:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760014462; x=1760619262; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sLVQWh+Znqw6JAYRNwQHXL1TFNSvZ0jniZ0MloD7+Hg=; b=g5oVRkXVT5siZ+2uCYxRWiUuy5l1gApuSF5A9Fzs83JPTZW75AHdjAuNAit0x3P+km GMOp/DlsWUDlp4pLgpKf85J4HCV4T5IqfPv0AeRLoyKSpL3Nw1YbJoOreWEHnpVIkQej dgznqsgN+Am2z2hxTDC05RFpXNhVnLiKN5OEePRX+7VRuSYSWPVQHL7ZKgHZFCmvVvno fv5WbICaN9rykWNAU6r127r0muUSgz7XtLu7Gk43qg+pVaGPgSvESpCP4WwzPfpto7om L1jjXDdI0ofrtAvupYcTkjrRM4yoqYqGSyRmQm4Zi2JwoZmKM2uE8i8wST90zjx6JmIw YL2g== X-Forwarded-Encrypted: i=1; AJvYcCUiXk6rPHHBC0+5IRNpve4Yc6vFO8I6+7P/pJZ+4+BAPZmOeE+vUGb7qRyNyaJUPdyoUH56et8=@vger.kernel.org X-Gm-Message-State: AOJu0YwhXigYT0yORRHh0tMvaeAUXpdByw/gQ1Jh6dV/aF9Us5Orqlf4 y8LJ0dMu3Dejbk81091qbZm7HZEOGORgyZ0DLUluB8WFudq6Ykt+JOv9I3nf/yKDlqlT5rHZPvX FMAoe1Gfw4X8I8YvR6IvPBTSVFWp///1tKiAjV1fvqjtPXnMMFq+PriiUAA== X-Gm-Gg: ASbGncuffem1TH5UC5QDBDAyhUrPHOk53X7MrxSRUr2VQ0uh0QfKLRGqUWlVbMFJncF 3q++8Dd2IbgJZxgxtkYwHsFtgvrCO8MxMOQ4bfkYYO6p17rtE8bF85M7RtdpXMb8lgAZmsD8NkX 3q+taniba4ajMonBkQb7Trf3JqkY6UY43SdNCcCu9cxEoTtBnLELBMoROUaqEdJpoK/hnAUvFcf cJGraolWGNTIYZ2TG3HT6S5m1YbKhO5s+/sxoBML7+VWIw0T+yL84l4QLSmrWKR0FsVGu2dTWUu nalyXmn01C2o7v6AQlb3MZzq0wf9m13VZ7U= X-Received: by 2002:a05:620a:269f:b0:82b:5e2e:bc46 with SMTP id af79cd13be357-8820d18e350mr1885887285a.35.1760014461755; Thu, 09 Oct 2025 05:54:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEqMpvtMJcanZP3rlvKbgdpkQAf5WVURwTPSiw1JSFVgNS1mLi/kxcHSU28QD1hy96VkYKztg== X-Received: by 2002:a05:620a:269f:b0:82b:5e2e:bc46 with SMTP id af79cd13be357-8820d18e350mr1885875985a.35.1760014460576; Thu, 09 Oct 2025 05:54:20 -0700 (PDT) Received: from redhat.com ([138.199.52.81]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8849f9ad8dasm190766385a.21.2025.10.09.05.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 05:54:20 -0700 (PDT) Date: Thu, 9 Oct 2025 08:54:15 -0400 From: "Michael S. Tsirkin" To: Andrew Lunn Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Paolo Abeni , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , kvm@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH 3/3] vhost: use checked versions of VIRTIO_BIT Message-ID: <20251009085057-mutt-send-email-mst@kernel.org> References: <6629538adfd821c8626ab8b9def49c23781e6775.1760008798.git.mst@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Oct 09, 2025 at 02:47:53PM +0200, Andrew Lunn wrote: > On Thu, Oct 09, 2025 at 07:24:16AM -0400, Michael S. Tsirkin wrote: > > This adds compile-time checked versions of VIRTIO_BIT that set bits in > > low and high qword, respectively. Will prevent confusion when people > > set bits in the wrong qword. > > > > Cc: "Paolo Abeni" > > Signed-off-by: Michael S. Tsirkin > > --- > > drivers/vhost/net.c | 4 ++-- > > include/linux/virtio_features.h | 9 +++++++++ > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > > index 43d51fb1f8ea..8b98e1a8baaa 100644 > > --- a/drivers/vhost/net.c > > +++ b/drivers/vhost/net.c > > @@ -76,8 +76,8 @@ static const u64 vhost_net_features[VIRTIO_FEATURES_QWORDS] = { > > (1ULL << VIRTIO_F_ACCESS_PLATFORM) | > > (1ULL << VIRTIO_F_RING_RESET) | > > (1ULL << VIRTIO_F_IN_ORDER), > > - VIRTIO_BIT(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO) | > > - VIRTIO_BIT(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO), > > + VIRTIO_BIT_HI(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO) | > > + VIRTIO_BIT_HI(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO), > > How any bits in vhost_net_features are currently in use? 68 > How likely is > it to go from 2x 64bit words to 3x 64 bit words? Maybe. > Rather than _LO, _HI, > would _1ST, _2ND be better leaving it open for _3RD? I can just open-code VIRTIO_BIT_QWORD(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO, 1) > I would also be tempted to rename these macros to include _LO_ and > _HI_ in them. VIRTIO_BIT_HI(VIRTIO_LO_F_IN_ORDER) is more likely to be > spotted as wrong this way. Hmm but with my macros compiler will warn so why uglify then? > An alternative would be to convert to a linux bitmap, which is > arbitrary length so you just use bit number and leave the > implementation to map that to the correct offset in the underlying > data structure. > > Andrew Right but it's a bit more work as we then have to change all drivers. Not ruling this out, but this patchset is not aiming that high. -- MST