[PATCH net-next 0/2] Add aarch64 support for FBNIC

[PATCH net-next 0/2] Add aarch64 support for FBNIC

[Dimitri Daskalakis]

We need to support aarch64 with 64K PAGE_SIZE, and I uncovered an issue
during testing.

Dimitri Daskalakis (2):
  net: fbnic: Fix page chunking logic when PAGE_SIZE > 4K
  net: fbnic: Allow builds for all 64 bit architectures

 drivers/net/ethernet/meta/Kconfig            | 2 +-
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.47.3

[PATCH net-next 1/2] net: fbnic: Fix page chunking logic when PAGE_SIZE > 4K

[Dimitri Daskalakis]

The HW always works on a 4K page size. When the OS supports larger
pages, we fragment them across multiple BDQ descriptors.
We were not properly incrementing the descriptor, which resulted in us
specifying the last chunks id/addr and then 15 zero descriptors. This
would cause packet loss and driver crashes. This is not a fix since the
Kconfig prevents use outside of x86.

Signed-off-by: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
index b1e8ce89870f..57e18a68f5d2 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
@@ -887,6 +887,7 @@ static void fbnic_bd_prep(struct fbnic_ring *bdq, u16 id, netmem_ref netmem)
 		*bdq_desc = cpu_to_le64(bd);
 		bd += FIELD_PREP(FBNIC_BD_DESC_ADDR_MASK, 1) |
 		      FIELD_PREP(FBNIC_BD_DESC_ID_MASK, 1);
+		bdq_desc++;
 	} while (--i);
 }
 
-- 
2.47.3

Re: [PATCH net-next 1/2] net: fbnic: Fix page chunking logic when PAGE_SIZE > 4K

[Simon Horman]

On Mon, Oct 13, 2025 at 02:14:48PM -0700, Dimitri Daskalakis wrote:
> The HW always works on a 4K page size. When the OS supports larger
> pages, we fragment them across multiple BDQ descriptors.
> We were not properly incrementing the descriptor, which resulted in us
> specifying the last chunks id/addr and then 15 zero descriptors. This
> would cause packet loss and driver crashes. This is not a fix since the
> Kconfig prevents use outside of x86.
> 
> Signed-off-by: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Simon Horman <horms@kernel.org>

[PATCH net-next 2/2] net: fbnic: Allow builds for all 64 bit architectures

[Dimitri Daskalakis]

This enables aarch64 testing, but there's no reason we cannot support other
architectures.

Signed-off-by: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/ethernet/meta/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/meta/Kconfig b/drivers/net/ethernet/meta/Kconfig
index 3ba527514f1e..dff51f23d295 100644
--- a/drivers/net/ethernet/meta/Kconfig
+++ b/drivers/net/ethernet/meta/Kconfig
@@ -19,7 +19,7 @@ if NET_VENDOR_META
 
 config FBNIC
 	tristate "Meta Platforms Host Network Interface"
-	depends on X86_64 || COMPILE_TEST
+	depends on 64BIT || COMPILE_TEST
 	depends on !S390
 	depends on MAX_SKB_FRAGS < 22
 	depends on PCI_MSI
-- 
2.47.3

Re: [PATCH net-next 2/2] net: fbnic: Allow builds for all 64 bit architectures

[Simon Horman]

On Mon, Oct 13, 2025 at 02:14:49PM -0700, Dimitri Daskalakis wrote:
> This enables aarch64 testing, but there's no reason we cannot support other
> architectures.
> 
> Signed-off-by: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next 0/2] Add aarch64 support for FBNIC

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Mon, 13 Oct 2025 14:14:47 -0700 you wrote:
> We need to support aarch64 with 64K PAGE_SIZE, and I uncovered an issue
> during testing.
> 
> Dimitri Daskalakis (2):
>   net: fbnic: Fix page chunking logic when PAGE_SIZE > 4K
>   net: fbnic: Allow builds for all 64 bit architectures
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: fbnic: Fix page chunking logic when PAGE_SIZE > 4K
    https://git.kernel.org/netdev/net-next/c/4bd451f4c285
  - [net-next,2/2] net: fbnic: Allow builds for all 64 bit architectures
    https://git.kernel.org/netdev/net-next/c/75b350839b9e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html