From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de, Celeste Liu <uwu@coelacanthus.name>,
stable@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH net 02/10] can: gs_usb: gs_make_candev(): populate net_device->dev_port
Date: Tue, 14 Oct 2025 14:17:49 +0200 [thread overview]
Message-ID: <20251014122140.990472-3-mkl@pengutronix.de> (raw)
In-Reply-To: <20251014122140.990472-1-mkl@pengutronix.de>
From: Celeste Liu <uwu@coelacanthus.name>
The gs_usb driver supports USB devices with more than 1 CAN channel.
In old kernel before 3.15, it uses net_device->dev_id to distinguish
different channel in userspace, which was done in commit
acff76fa45b4 ("can: gs_usb: gs_make_candev(): set netdev->dev_id").
But since 3.15, the correct way is populating net_device->dev_port.
And according to documentation, if network device support multiple
interface, lack of net_device->dev_port SHALL be treated as a bug.
Fixes: acff76fa45b4 ("can: gs_usb: gs_make_candev(): set netdev->dev_id")
Cc: stable@vger.kernel.org
Signed-off-by: Celeste Liu <uwu@coelacanthus.name>
Link: https://patch.msgid.link/20250930-gs-usb-populate-net_device-dev_port-v1-1-68a065de6937@coelacanthus.name
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/usb/gs_usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 9fb4cbbd6d6d..69b8d6da651b 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -1245,6 +1245,7 @@ static struct gs_can *gs_make_candev(unsigned int channel,
netdev->flags |= IFF_ECHO; /* we support full roundtrip echo */
netdev->dev_id = channel;
+ netdev->dev_port = channel;
/* dev setup */
strcpy(dev->bt_const.name, KBUILD_MODNAME);
--
2.51.0
next prev parent reply other threads:[~2025-10-14 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 12:17 [PATCH net 0/10] pull-request: can 2025-10-14 Marc Kleine-Budde
2025-10-14 12:17 ` [PATCH net 01/10] can: gs_usb: increase max interface to U8_MAX Marc Kleine-Budde
2025-10-16 1:20 ` patchwork-bot+netdevbpf
2025-10-14 12:17 ` Marc Kleine-Budde [this message]
2025-10-14 12:17 ` [PATCH net 03/10] can: m_can: m_can_plat_remove(): add missing pm_runtime_disable() Marc Kleine-Budde
2025-10-14 12:17 ` [PATCH net 04/10] can: m_can: m_can_handle_state_errors(): fix CAN state transition to Error Active Marc Kleine-Budde
2025-10-14 12:17 ` [PATCH net 05/10] can: m_can: m_can_chip_config(): bring up interface in correct state Marc Kleine-Budde
2025-10-14 12:17 ` [PATCH net 06/10] can: m_can: fix CAN state in system PM Marc Kleine-Budde
2025-10-14 12:17 ` [PATCH net 07/10] can: m_can: replace Dong Aisheng's old email address Marc Kleine-Budde
2025-10-14 12:17 ` [PATCH net 08/10] can: remove false statement about 1:1 mapping between DLC and length Marc Kleine-Budde
2025-10-14 12:17 ` [PATCH net 09/10] can: add Transmitter Delay Compensation (TDC) documentation Marc Kleine-Budde
2025-10-14 12:17 ` [PATCH net 10/10] can: j1939: add missing calls in NETDEV_UNREGISTER notification handler Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014122140.990472-3-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=uwu@coelacanthus.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).