* [PATCH ethtool-next v2] netlink: fec: add errors histogram statistics
@ 2025-10-14 21:20 Vadim Fedorenko
2025-10-15 20:22 ` Jacob Keller
0 siblings, 1 reply; 2+ messages in thread
From: Vadim Fedorenko @ 2025-10-14 21:20 UTC (permalink / raw)
To: mkubecek; +Cc: Vadim Fedorenko, Jakub Kicinski, netdev
Linux 6.18 has FEC errors histogram statistics API added. Add support
for extra attributes in ethtool.
# ethtool -I --show-fec eni8np1
FEC parameters for eni8np1:
Supported/Configured FEC encodings: None
Active FEC encoding: None
Statistics:
corrected_blocks: 123
uncorrectable_blocks: 4
fec_symbol_err_0: 445 [ per_lane: 125, 120, 100, 100 ]
fec_symbol_err_1_to_3: 12
fec_symbol_err_4_to_7: 2
# ethtool -j -I --show-fec eni8np1
[ {
"ifname": "eni8np1",
"config": [ "None" ],
"active": [ "None" ],
"statistics": {
"corrected_blocks": {
"total": 123
},
"uncorrectable_blocks": {
"total": 4
},
"hist": [ {
"bin_low": 0,
"bin_high": 0,
"total": 445,
"lanes": [ 125,120,100,100 ]
},{
"bin_low": 1,
"bin_high": 3,
"total": 12
},{
"bin_low": 4,
"bin_high": 7,
"total": 2
} ]
}
} ]
Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
---
v1 -> v2:
- change field name fec_bit_error -> fec_symbol_error as by standard
- align format of blocks per-lane statistics to histogram per-lane
netlink/fec.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 81 insertions(+), 5 deletions(-)
diff --git a/netlink/fec.c b/netlink/fec.c
index ed100d7..36ad3f5 100644
--- a/netlink/fec.c
+++ b/netlink/fec.c
@@ -44,6 +44,64 @@ fec_mode_walk(unsigned int idx, const char *name, bool val, void *data)
print_string(PRINT_ANY, NULL, " %s", name);
}
+static void fec_show_hist_bin(const struct nlattr *hist)
+{
+ const struct nlattr *tb[ETHTOOL_A_FEC_HIST_MAX + 1] = {};
+ DECLARE_ATTR_TB_INFO(tb);
+ unsigned int i, lanes, bin_high, bin_low;
+ uint64_t val, *vals;
+ int ret;
+
+ ret = mnl_attr_parse_nested(hist, attr_cb, &tb_info);
+ if (ret < 0)
+ return;
+
+ if (!tb[ETHTOOL_A_FEC_HIST_BIN_LOW] || !tb[ETHTOOL_A_FEC_HIST_BIN_HIGH])
+ return;
+
+ bin_high = mnl_attr_get_u32(tb[ETHTOOL_A_FEC_HIST_BIN_HIGH]);
+ bin_low = mnl_attr_get_u32(tb[ETHTOOL_A_FEC_HIST_BIN_LOW]);
+ /* Bin value is uint, so it may be u32 or u64 depeding on the value */
+ if (mnl_attr_validate(tb[ETHTOOL_A_FEC_HIST_BIN_VAL], MNL_TYPE_U32) < 0)
+ val = mnl_attr_get_u64(tb[ETHTOOL_A_FEC_HIST_BIN_VAL]);
+ else
+ val = mnl_attr_get_u32(tb[ETHTOOL_A_FEC_HIST_BIN_VAL]);
+
+ if (is_json_context()) {
+ print_u64(PRINT_JSON, "bin_low", NULL, bin_low);
+ print_u64(PRINT_JSON, "bin_high", NULL, bin_high);
+ print_u64(PRINT_JSON, "total", NULL, val);
+ } else {
+ printf(" fec_symbols_err_%d", bin_low);
+ if (bin_low != bin_high)
+ printf("_to_%d", bin_high);
+ printf(": %" PRIu64, val);
+ }
+ if (!tb[ETHTOOL_A_FEC_HIST_BIN_VAL_PER_LANE]) {
+ if (!is_json_context())
+ print_nl();
+ return;
+ }
+
+ vals = mnl_attr_get_payload(tb[ETHTOOL_A_FEC_HIST_BIN_VAL_PER_LANE]);
+ lanes = mnl_attr_get_payload_len(tb[ETHTOOL_A_FEC_HIST_BIN_VAL_PER_LANE]) / 8;
+ if (is_json_context())
+ open_json_array("lanes", "");
+ else
+ printf(" [ per_lane:");
+ for (i = 0; i < lanes; i++) {
+ if (is_json_context())
+ print_u64(PRINT_JSON, NULL, NULL, *vals++);
+ else
+ printf("%s %" PRIu64, i ? "," : "", *vals++);
+ }
+
+ if (is_json_context())
+ close_json_array("");
+ else
+ printf(" ]\n");
+}
+
static int fec_show_stats(const struct nlattr *nest)
{
const struct nlattr *tb[ETHTOOL_A_FEC_STAT_MAX + 1] = {};
@@ -87,27 +145,45 @@ static int fec_show_stats(const struct nlattr *nest)
lanes = mnl_attr_get_payload_len(tb[stats[i].attr]) / 8 - 1;
if (!is_json_context()) {
- fprintf(stdout, " %s: %" PRIu64 "\n",
+ fprintf(stdout, " %s: %" PRIu64,
stats[i].name, *vals++);
} else {
open_json_object(stats[i].name);
print_u64(PRINT_JSON, "total", NULL, *vals++);
}
- if (lanes)
+ if (lanes) {
open_json_array("lanes", "");
+ printf(" [ per_lane:");
+ }
+
for (l = 0; l < lanes; l++) {
if (!is_json_context())
- fprintf(stdout, " Lane %d: %" PRIu64 "\n",
- l, *vals++);
+ printf("%s %" PRIu64, l ? "," : "", *vals++);
else
print_u64(PRINT_JSON, NULL, NULL, *vals++);
}
- if (lanes)
+ if (lanes) {
close_json_array("");
+ printf(" ]\n");
+ }
close_json_object();
}
+
+ if (tb[ETHTOOL_A_FEC_STAT_HIST]) {
+ const struct nlattr *attr;
+
+ open_json_array("hist", "");
+ mnl_attr_for_each_nested(attr, nest) {
+ if (mnl_attr_get_type(attr) == ETHTOOL_A_FEC_STAT_HIST) {
+ open_json_object(NULL);
+ fec_show_hist_bin(attr);
+ close_json_object();
+ }
+ }
+ close_json_array("");
+ }
close_json_object();
return 0;
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH ethtool-next v2] netlink: fec: add errors histogram statistics
2025-10-14 21:20 [PATCH ethtool-next v2] netlink: fec: add errors histogram statistics Vadim Fedorenko
@ 2025-10-15 20:22 ` Jacob Keller
0 siblings, 0 replies; 2+ messages in thread
From: Jacob Keller @ 2025-10-15 20:22 UTC (permalink / raw)
To: Vadim Fedorenko, mkubecek; +Cc: Jakub Kicinski, netdev
[-- Attachment #1.1: Type: text/plain, Size: 1480 bytes --]
On 10/14/2025 2:20 PM, Vadim Fedorenko wrote:
> Linux 6.18 has FEC errors histogram statistics API added. Add support
> for extra attributes in ethtool.
>
> # ethtool -I --show-fec eni8np1
> FEC parameters for eni8np1:
> Supported/Configured FEC encodings: None
> Active FEC encoding: None
> Statistics:
> corrected_blocks: 123
> uncorrectable_blocks: 4
> fec_symbol_err_0: 445 [ per_lane: 125, 120, 100, 100 ]
> fec_symbol_err_1_to_3: 12
> fec_symbol_err_4_to_7: 2
>
> # ethtool -j -I --show-fec eni8np1
> [ {
> "ifname": "eni8np1",
> "config": [ "None" ],
> "active": [ "None" ],
> "statistics": {
> "corrected_blocks": {
> "total": 123
> },
> "uncorrectable_blocks": {
> "total": 4
> },
> "hist": [ {
> "bin_low": 0,
> "bin_high": 0,
> "total": 445,
> "lanes": [ 125,120,100,100 ]
> },{
> "bin_low": 1,
> "bin_high": 3,
> "total": 12
> },{
> "bin_low": 4,
> "bin_high": 7,
> "total": 2
> } ]
> }
> } ]
>
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-15 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14 21:20 [PATCH ethtool-next v2] netlink: fec: add errors histogram statistics Vadim Fedorenko
2025-10-15 20:22 ` Jacob Keller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).