[PATCH net-next] netdevsim: add ipsec hw_features

[PATCH net-next] netdevsim: add ipsec hw_features

[Hangbin Liu]

Currently, netdevsim only sets dev->features, which makes the ESP features
fixed. For example:

  # ethtool -k eni0np1 | grep esp
  tx-esp-segmentation: on [fixed]
  esp-hw-offload: on [fixed]
  esp-tx-csum-hw-offload: on [fixed]

This patch adds the ESP features to hw_features, allowing them to be
changed manually. For example:

  # ethtool -k eni0np1 | grep esp
  tx-esp-segmentation: on
  esp-hw-offload: on
  esp-tx-csum-hw-offload: on

Suggested-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 drivers/net/netdevsim/ipsec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/netdevsim/ipsec.c b/drivers/net/netdevsim/ipsec.c
index 47cdee5577d4..36a1be4923d6 100644
--- a/drivers/net/netdevsim/ipsec.c
+++ b/drivers/net/netdevsim/ipsec.c
@@ -277,6 +277,7 @@ void nsim_ipsec_init(struct netdevsim *ns)
 				 NETIF_F_GSO_ESP)
 
 	ns->netdev->features |= NSIM_ESP_FEATURES;
+	ns->netdev->hw_features |= NSIM_ESP_FEATURES;
 	ns->netdev->hw_enc_features |= NSIM_ESP_FEATURES;
 
 	ns->ipsec.pfile = debugfs_create_file("ipsec", 0400,
-- 
2.50.1

Re: [PATCH net-next] netdevsim: add ipsec hw_features

[Sabrina Dubroca]

2025-10-15, 08:36:49 +0000, Hangbin Liu wrote:
> Currently, netdevsim only sets dev->features, which makes the ESP features
> fixed. For example:
> 
>   # ethtool -k eni0np1 | grep esp
>   tx-esp-segmentation: on [fixed]
>   esp-hw-offload: on [fixed]
>   esp-tx-csum-hw-offload: on [fixed]
> 
> This patch adds the ESP features to hw_features, allowing them to be
> changed manually. For example:
> 
>   # ethtool -k eni0np1 | grep esp
>   tx-esp-segmentation: on
>   esp-hw-offload: on
>   esp-tx-csum-hw-offload: on
> 
> Suggested-by: Sabrina Dubroca <sd@queasysnail.net>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>

Thanks Hangbin.

-- 
Sabrina

Re: [PATCH net-next] netdevsim: add ipsec hw_features

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 15 Oct 2025 08:36:49 +0000 you wrote:
> Currently, netdevsim only sets dev->features, which makes the ESP features
> fixed. For example:
> 
>   # ethtool -k eni0np1 | grep esp
>   tx-esp-segmentation: on [fixed]
>   esp-hw-offload: on [fixed]
>   esp-tx-csum-hw-offload: on [fixed]
> 
> [...]

Here is the summary with links:
  - [net-next] netdevsim: add ipsec hw_features
    https://git.kernel.org/netdev/net-next/c/38c31c2620de

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html