From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: David Wilder <wilder@us.ibm.com>,
netdev@vger.kernel.org, jv@jvosburgh.net, pradeep@us.ibm.com,
i.maximets@ovn.org, amorenoz@redhat.com, haliu@redhat.com,
stephen@networkplumber.org, horms@kernel.org,
andrew+netdev@lunn.ch, edumazet@google.com
Subject: Re: [PATCH net-next v13 6/7] bonding: Update for extended arp_ip_target format.
Date: Thu, 16 Oct 2025 12:49:08 -0700 [thread overview]
Message-ID: <20251016124908.759bbb63@kernel.org> (raw)
In-Reply-To: <ef443366-f841-4a84-9409-818fc31b2c0c@redhat.com>
On Thu, 16 Oct 2025 13:50:52 +0200 Paolo Abeni wrote:
> > + if (nla_put(skb, i, size, &data))
> > + goto nla_put_failure;
> > }
> >
> > if (targets_added)
>
> I guess you should update bond_get_size() accordingly???
>
> Also changing the binary layout of an existing NL type does not feel
> safe. @Jakub: is that something we can safely allow?
In general extending attributes is fine, but going from a scalar
to a struct is questionable. YNL for example will not allow it.
I haven't looked at the series more closely until now.
Why are there multiple vlan tags per target?
Is this configuration really something we should support in the kernel?
IDK how much we should push "OvS-compatibility" into other parts of the
stack. If user knows that they have to apply this funny configuration
on the bond maybe they should just arp from user space?
next prev parent reply other threads:[~2025-10-16 19:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 23:52 [PATCH net-next v13 0/7] bonding: Extend arp_ip_target format to allow for a list of vlan tags David Wilder
2025-10-13 23:52 ` [PATCH net-next v13 1/7] bonding: Adding struct bond_arp_target David Wilder
2025-10-13 23:52 ` [PATCH net-next v13 2/7] bonding: Adding extra_len field to struct bond_opt_value David Wilder
2025-10-13 23:52 ` [PATCH net-next v13 3/7] bonding: arp_ip_target helpers David Wilder
2025-10-16 11:14 ` Paolo Abeni
2025-10-13 23:52 ` [PATCH net-next v13 4/7] bonding: Processing extended arp_ip_target from user space David Wilder
2025-10-16 11:26 ` Paolo Abeni
2025-10-13 23:52 ` [PATCH net-next v13 5/7] bonding: Update to bond_arp_send_all() to use supplied vlan tags David Wilder
2025-10-16 11:38 ` Paolo Abeni
2025-10-13 23:52 ` [PATCH net-next v13 6/7] bonding: Update for extended arp_ip_target format David Wilder
2025-10-16 11:50 ` Paolo Abeni
2025-10-16 19:49 ` Jakub Kicinski [this message]
2025-10-17 0:21 ` David Wilder
2025-10-21 16:00 ` David Wilder
2025-10-21 16:18 ` David Wilder
2025-10-21 22:56 ` Jakub Kicinski
2025-10-13 23:52 ` [PATCH net-next v13 7/7] bonding: Selftest and documentation for the arp_ip_target parameter David Wilder
2025-10-16 11:55 ` Paolo Abeni
2025-10-16 11:48 ` [PATCH net-next v13 0/7] bonding: Extend arp_ip_target format to allow for a list of vlan tags Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016124908.759bbb63@kernel.org \
--to=kuba@kernel.org \
--cc=amorenoz@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=edumazet@google.com \
--cc=haliu@redhat.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jv@jvosburgh.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pradeep@us.ibm.com \
--cc=stephen@networkplumber.org \
--cc=wilder@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).