Build commit for Patchwork?

Build commit for Patchwork?

[John Ousterhout]

Is there a way to tell which commit Patchwork uses for its builds?

Patchwork builds are generating this error:

‘struct flowi_common’ has no member named ‘flowic_tos’; did you mean
‘flowic_oif’?

(https://netdev.bots.linux.dev/static/nipa/1012035/14269094/build_32bit/stderr)

but the member flowic_tos seems to be present in all recent commits
that I can find.

-John-

Re: Build commit for Patchwork?

[Simon Horman]

On Thu, Oct 16, 2025 at 09:07:09AM -0700, John Ousterhout wrote:
> Is there a way to tell which commit Patchwork uses for its builds?
> 
> Patchwork builds are generating this error:
> 
> ‘struct flowi_common’ has no member named ‘flowic_tos’; did you mean
> ‘flowic_oif’?
> 
> (https://netdev.bots.linux.dev/static/nipa/1012035/14269094/build_32bit/stderr)
> 
> but the member flowic_tos seems to be present in all recent commits
> that I can find.

Hi John,

I'm not sure that it's explicitly exposed.
But if you look at one of the builds for the 1st patch of the series
then it will start with a baseline build (that is, build of the
tree the patch-set is applied on top of).

In this case, looking at the URL below, which is linked from
the first patch in the series in Patchwork, I see.

cb85ca4c0a34 ("Merge branch 'net-airoha-npu-introduce-support-for-airoha-7583-npu'")

https://netdev.bots.linux.dev/static/nipa/1012035/14269097/build_32bit/stdout

Re: Build commit for Patchwork?

[Ilya Maximets]

On 10/16/25 6:25 PM, Simon Horman wrote:
> On Thu, Oct 16, 2025 at 09:07:09AM -0700, John Ousterhout wrote:
>> Is there a way to tell which commit Patchwork uses for its builds?
>>
>> Patchwork builds are generating this error:
>>
>> ‘struct flowi_common’ has no member named ‘flowic_tos’; did you mean
>> ‘flowic_oif’?
>>
>> (https://netdev.bots.linux.dev/static/nipa/1012035/14269094/build_32bit/stderr)
>>
>> but the member flowic_tos seems to be present in all recent commits
>> that I can find.
> 
> Hi John,
> 
> I'm not sure that it's explicitly exposed.
> But if you look at one of the builds for the 1st patch of the series
> then it will start with a baseline build (that is, build of the
> tree the patch-set is applied on top of).
> 
> In this case, looking at the URL below, which is linked from
> the first patch in the series in Patchwork, I see.
> 
> cb85ca4c0a34 ("Merge branch 'net-airoha-npu-introduce-support-for-airoha-7583-npu'")
> 
> https://netdev.bots.linux.dev/static/nipa/1012035/14269097/build_32bit/stdout

My understanding is that it just builds on the tip of net-next/main
whatever it is at the moment the build starts.

FWIW, the field was renamed on net-next at the end of August:
  https://lore.kernel.org/netdev/29acecb45e911d17446b9a3dbdb1ab7b821ea371.1756128932.git.gnault@redhat.com/

Best regards, Ilya Maximets.

Re: Build commit for Patchwork?

[Jakub Kicinski]

On Thu, 16 Oct 2025 18:57:31 +0200 Ilya Maximets wrote:
> My understanding is that it just builds on the tip of net-next/main
> whatever it is at the moment the build starts.

That's right. Check out a branch matching net-next and you can run all
the checks locally:

https://github.com/linux-netdev/nipa?tab=readme-ov-file#running-locally

Re: Build commit for Patchwork?

[Andrew Lunn]

On Thu, Oct 16, 2025 at 09:07:09AM -0700, John Ousterhout wrote:
> Is there a way to tell which commit Patchwork uses for its builds?
> 
> Patchwork builds are generating this error:
> 
> ‘struct flowi_common’ has no member named ‘flowic_tos’; did you mean
> ‘flowic_oif’?

commit 1bec9d0c0046fe4e2bfb6a1c5aadcb5d56cdb0fb
Author: Guillaume Nault <gnault@redhat.com>
Date:   Mon Aug 25 15:37:43 2025 +0200

    ipv4: Convert ->flowi4_tos to dscp_t.

diff --git a/include/net/flow.h b/include/net/flow.h
index a1839c278d87..ae9481c40063 100644
--- a/include/net/flow.h
+++ b/include/net/flow.h
@@ -12,6 +12,7 @@
 #include <linux/atomic.h>
 #include <linux/container_of.h>
 #include <linux/uidgid.h>
+#include <net/inet_dscp.h>
 
 struct flow_keys;
 
@@ -32,7 +33,7 @@ struct flowi_common {
        int     flowic_iif;
        int     flowic_l3mdev;
        __u32   flowic_mark;
-       __u8    flowic_tos;
+       dscp_t  flowic_dscp;
        __u8    flowic_scope;
        __u8    flowic_proto;
        __u8    flowic_flags;

Andrew