netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wen Xin <w_xin@apple.com>
To: netdev@vger.kernel.org
Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
	eperezma@redhat.com, virtualization@lists.linux.dev,
	Wen Xin <w_xin@apple.com>
Subject: [PATCH net] virtio_net: fix header access in big_packets mode
Date: Thu, 16 Oct 2025 15:33:05 -0700	[thread overview]
Message-ID: <20251016223305.51435-1-w_xin@apple.com> (raw)

In Linux virtio-net driver's (drivers/net/virtio_net.c) big packets mode (vi->big_packets && vi->mergeable_rx_bufs), the buf
pointer passed to receive_buf() is a struct page pointer, not a buffer
pointer. The current code incorrectly casts this page pointer directly as
a virtio_net_common_hdr, causing it to read flags from the page struct
memory instead of the actual packet data.

Signed-off-by: Wen Xin <w_xin@apple.com>
---
 drivers/net/virtio_net.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 7646ddd9bef7..c10f5585bc88 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2566,7 +2566,13 @@ static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq,
 	 * virtnet_xdp_set()), so packets marked as
 	 * VIRTIO_NET_HDR_F_NEEDS_CSUM get dropped during XDP processing.
 	 */
-	flags = ((struct virtio_net_common_hdr *)buf)->hdr.flags;
+	if (vi->big_packets && !vi->mergeable_rx_bufs) {
+		struct virtio_net_common_hdr *hdr = page_address((struct page *)buf);
+
+		flags = hdr->hdr.flags;
+	} else {
+		flags = ((struct virtio_net_common_hdr *)buf)->hdr.flags;
+	}
 
 	if (vi->mergeable_rx_bufs)
 		skb = receive_mergeable(dev, vi, rq, buf, ctx, len, xdp_xmit,
-- 
2.39.5 (Apple Git-154)


             reply	other threads:[~2025-10-16 23:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 22:33 Wen Xin [this message]
2025-10-17  0:57 ` [PATCH net] virtio_net: fix header access in big_packets mode Xuan Zhuo
2025-10-17 23:38   ` Jakub Kicinski
2025-10-22  1:42     ` Xuan Zhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251016223305.51435-1-w_xin@apple.com \
    --to=w_xin@apple.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).