[PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default

[PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default

[michael.opdenacker]

From: Michael Opdenacker <michael.opdenacker@rootcommit.com>

Supports booting boards on NFS filesystems, without going
through an initramfs.

Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
 drivers/net/ethernet/spacemit/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/spacemit/Kconfig b/drivers/net/ethernet/spacemit/Kconfig
index 85ef61a9b4ef..7fe1b2a308d1 100644
--- a/drivers/net/ethernet/spacemit/Kconfig
+++ b/drivers/net/ethernet/spacemit/Kconfig
@@ -18,7 +18,7 @@ config SPACEMIT_K1_EMAC
 	depends on ARCH_SPACEMIT || COMPILE_TEST
 	depends on MFD_SYSCON
 	depends on OF
-	default m if ARCH_SPACEMIT
+	default y if ARCH_SPACEMIT
 	select PHYLIB
 	help
 	  This driver supports the Ethernet MAC in the SpacemiT K1 SoC.

Re: [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default

[Emil Renner Berthing]

On Fri, 17 Oct 2025 at 12:03, <michael.opdenacker@rootcommit.com> wrote:
>
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> Supports booting boards on NFS filesystems, without going
> through an initramfs.

Please don't do this. If we build in every ethernet driver that might
be used to boot from NFS we'll end up with almost every driver
built-in and huge kernels. If you need this there is nothing
preventing you from building the driver in, but please don't bloat
defconfig kernels for everyone else.

/Emil

Re: [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default

[Michael Opdenacker]

Hi Emil

Thanks for the review!

On 10/17/25 17:33, Emil Renner Berthing wrote:
> On Fri, 17 Oct 2025 at 12:03, <michael.opdenacker@rootcommit.com> wrote:
>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> Supports booting boards on NFS filesystems, without going
>> through an initramfs.
> Please don't do this. If we build in every ethernet driver that might
> be used to boot from NFS we'll end up with almost every driver
> built-in and huge kernels. If you need this there is nothing
> preventing you from building the driver in, but please don't bloat
> defconfig kernels for everyone else.

Understood. You have a point. It's not really a problem to customize 
kernel configuration for each board as you said.
So, please forget this particular patch :)
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com