* [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default [not found] <20251017100106.3180482-1-michael.opdenacker@rootcommit.com> @ 2025-10-17 10:02 ` michael.opdenacker 2025-10-17 15:33 ` Emil Renner Berthing 0 siblings, 1 reply; 3+ messages in thread From: michael.opdenacker @ 2025-10-17 10:02 UTC (permalink / raw) To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yixun Lan Cc: Michael Opdenacker, netdev, linux-riscv, spacemit, linux-kernel From: Michael Opdenacker <michael.opdenacker@rootcommit.com> Supports booting boards on NFS filesystems, without going through an initramfs. Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> --- drivers/net/ethernet/spacemit/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/spacemit/Kconfig b/drivers/net/ethernet/spacemit/Kconfig index 85ef61a9b4ef..7fe1b2a308d1 100644 --- a/drivers/net/ethernet/spacemit/Kconfig +++ b/drivers/net/ethernet/spacemit/Kconfig @@ -18,7 +18,7 @@ config SPACEMIT_K1_EMAC depends on ARCH_SPACEMIT || COMPILE_TEST depends on MFD_SYSCON depends on OF - default m if ARCH_SPACEMIT + default y if ARCH_SPACEMIT select PHYLIB help This driver supports the Ethernet MAC in the SpacemiT K1 SoC. ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default 2025-10-17 10:02 ` [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default michael.opdenacker @ 2025-10-17 15:33 ` Emil Renner Berthing 2025-10-17 15:53 ` Michael Opdenacker 0 siblings, 1 reply; 3+ messages in thread From: Emil Renner Berthing @ 2025-10-17 15:33 UTC (permalink / raw) To: michael.opdenacker Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yixun Lan, netdev, linux-riscv, spacemit, linux-kernel On Fri, 17 Oct 2025 at 12:03, <michael.opdenacker@rootcommit.com> wrote: > > From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > Supports booting boards on NFS filesystems, without going > through an initramfs. Please don't do this. If we build in every ethernet driver that might be used to boot from NFS we'll end up with almost every driver built-in and huge kernels. If you need this there is nothing preventing you from building the driver in, but please don't bloat defconfig kernels for everyone else. /Emil ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default 2025-10-17 15:33 ` Emil Renner Berthing @ 2025-10-17 15:53 ` Michael Opdenacker 0 siblings, 0 replies; 3+ messages in thread From: Michael Opdenacker @ 2025-10-17 15:53 UTC (permalink / raw) To: Emil Renner Berthing Cc: michael.opdenacker, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Yixun Lan, netdev, linux-riscv, spacemit, linux-kernel Hi Emil Thanks for the review! On 10/17/25 17:33, Emil Renner Berthing wrote: > On Fri, 17 Oct 2025 at 12:03, <michael.opdenacker@rootcommit.com> wrote: >> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >> >> Supports booting boards on NFS filesystems, without going >> through an initramfs. > Please don't do this. If we build in every ethernet driver that might > be used to boot from NFS we'll end up with almost every driver > built-in and huge kernels. If you need this there is nothing > preventing you from building the driver in, but please don't bloat > defconfig kernels for everyone else. Understood. You have a point. It's not really a problem to customize kernel configuration for each board as you said. So, please forget this particular patch :) Cheers Michael. -- Michael Opdenacker Root Commit Embedded Linux Training and Consulting https://rootcommit.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-17 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251017100106.3180482-1-michael.opdenacker@rootcommit.com>
2025-10-17 10:02 ` [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default michael.opdenacker
2025-10-17 15:33 ` Emil Renner Berthing
2025-10-17 15:53 ` Michael Opdenacker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).