From: Jakub Kicinski <kuba@kernel.org>
To: Lizhi Xu <lizhi.xu@windriver.com>
Cc: <ahmed.zaki@intel.com>, <aleksander.lobakin@intel.com>,
<davem@davemloft.net>, <edumazet@google.com>, <horms@kernel.org>,
<kuniyu@amazon.com>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<samsun1006219@gmail.com>, <sdf@fomichev.me>,
<syzkaller-bugs@googlegroups.com>, <syzkaller@googlegroups.com>
Subject: Re: [PATCH V2] usbnet: Prevents free active kevent
Date: Fri, 17 Oct 2025 15:27:31 -0700 [thread overview]
Message-ID: <20251017152731.4bb7f1f9@kernel.org> (raw)
In-Reply-To: <20251017090541.3705538-1-lizhi.xu@windriver.com>
On Fri, 17 Oct 2025 17:05:41 +0800 Lizhi Xu wrote:
> The root cause of this issue are:
> 1. When probing the usbnet device, executing usbnet_link_change(dev, 0, 0);
> put the kevent work in global workqueue. However, the kevent has not yet
> been scheduled when the usbnet device is unregistered. Therefore, executing
> free_netdev() results in the "free active object (kevent)" error reported
> here.
>
> 2. Another factor is that when calling usbnet_disconnect()->unregister_netdev(),
> if the usbnet device is up, ndo_stop() is executed to cancel the kevent.
> However, because the device is not up, ndo_stop() is not executed.
>
> The solution to this problem is to cancel the kevent before executing
> free_netdev(), which also deletes the delay timer.
Please add a fixes tag, and repost.
Please don't send new versions in reply to previous / existing threads.
Please read at least the tl;dr of:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
--
pw-bot: cr
next prev parent reply other threads:[~2025-10-17 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 13:10 [Linux Kernel Bug] WARNING: ODEBUG bug in free_netdev Sam Sun
2025-10-17 8:49 ` [PATCH] usbnet: Prevents free active kevent Lizhi Xu
2025-10-17 9:05 ` [PATCH V2] " Lizhi Xu
2025-10-17 22:27 ` Jakub Kicinski [this message]
2025-10-18 2:54 ` Lizhi Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017152731.4bb7f1f9@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=samsun1006219@gmail.com \
--cc=sdf@fomichev.me \
--cc=syzkaller-bugs@googlegroups.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).