From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A74A1FDE39; Sun, 19 Oct 2025 22:25:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760912747; cv=none; b=a5on53ComoqLcBzADWm3RX7D5XWmSBUYnUxRwbLyLudo0O8xoHWOThdu+qiDPy7PgyC6S8LdGmh9N3/D5PCyRvAO+RLN6N6gF2xwiGw/WbdeYupuf4jI+VSa7CkcUUsvotfilO0S8Umj1Q60LdK7bc+wqTPicFcNBiYiU0rxu2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760912747; c=relaxed/simple; bh=gAJO6XNxvcd/2gE+vHM20/r2IfLcuHET+ONuD0vyfQQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=stoz1ty4TmmYffXIUaPQLCcHUiqEwEVqsg9M3dsbXMUmlQOHqvCYKLHV8ZTnjl1oIx68C3rXPAfSjzIqUrH9d7O3GWImn0Zc4GZKfbcLEiS8RYbnyD/TSyLk0NF5NVo0LmxVJCTDGep1nnWhyyXd4rdFJwjIjcSj9GEutzITHXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T91ZzqUH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T91ZzqUH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34408C4CEE7; Sun, 19 Oct 2025 22:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760912747; bh=gAJO6XNxvcd/2gE+vHM20/r2IfLcuHET+ONuD0vyfQQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T91ZzqUHux4tfVX2iNR01ns/APtCWhjQvpCODIIMbRXmJ49utg82qiGNIziWjRa43 RTUXmPuIVDO2modjHnm8JkZEsWY0XorTcZLN/tHb+bgSrEow5ZAMeHhtwHOzSKp+oA ws24pUhQEDEHowtY3WbRCd61KVCIJMR9vrtbzOxsaWuit05h0dD5h/rwTk2WeY13n6 h5mt5RWZ0yKeIHTdzUdOlsrLXMjjCCsjpBMNFIhTelpjpIwLEzBoQvXoNruUigH6Je pif1oRZA9/Bo6GTK7o4rfqgTcpoOvgYEeql4zDFWoEg7M5XFpJhlvBOPmeyWZQEd7D EJk15wI89eHHA== Date: Sun, 19 Oct 2025 15:25:45 -0700 From: Jakub Kicinski To: Daniel Golle Cc: Hauke Mehrtens , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Schirm , Lukas Stockmann , Alexander Sverdlin , Peter Christen , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: Re: [PATCH net-next v3 4/7] net: dsa: lantiq_gswip: manually convert remaining uses of read accessors Message-ID: <20251019152545.524ac596@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 19 Oct 2025 13:48:36 +0100 Daniel Golle wrote: > + for (i = 0; i < ARRAY_SIZE(tbl->key); i++) { > + err = regmap_read(priv->gswip, GSWIP_PCE_TBL_KEY(i), &tmp); > + if (err) > + return err; > + tbl->key[i] = tmp; > + } > + for (i = 0; i < ARRAY_SIZE(tbl->val); i++) { > + err = regmap_read(priv->gswip, GSWIP_PCE_TBL_VAL(i), &tmp); > + if (err) > + return err; > + tbl->val[i] = tmp; > + } > > - tbl->mask = gswip_switch_r(priv, GSWIP_PCE_TBL_MASK); > + err = regmap_read(priv->gswip, GSWIP_PCE_TBL_MASK, &tmp); > + if (err) > + return err; > > - crtl = gswip_switch_r(priv, GSWIP_PCE_TBL_CTRL); > + tbl->mask = tmp; > + err = regmap_read(priv->gswip, GSWIP_PCE_TBL_CTRL, &tmp); > + if (err) > + return err; Coccicheck points out we're holding a mutex here, can't return directly. -- pw-bot: cr