netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v2] bnxt_en: support PPS in/out on all pins
@ 2025-10-19 22:57 Vadim Fedorenko
  2025-10-20 11:08 ` Pavan Chebbi
  2025-10-22  1:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2025-10-19 22:57 UTC (permalink / raw)
  To: Michael Chan, Pavan Chebbi, Jakub Kicinski
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
	Richard Cochran, netdev, Vadim Fedorenko

Add supported_extts_flags and supported_perout_flags configuration to make
the driver complaint with the latest API.

Initialize channel information to 0 to avoid confusing users, because HW
doesn't actually care about channels.

Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
index db81cf6d5289..1425a75de9a1 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
@@ -952,7 +952,6 @@ static int bnxt_ptp_pps_init(struct bnxt *bp)
 		snprintf(ptp_info->pin_config[i].name,
 			 sizeof(ptp_info->pin_config[i].name), "bnxt_pps%d", i);
 		ptp_info->pin_config[i].index = i;
-		ptp_info->pin_config[i].chan = i;
 		if (*pin_usg == BNXT_PPS_PIN_PPS_IN)
 			ptp_info->pin_config[i].func = PTP_PF_EXTTS;
 		else if (*pin_usg == BNXT_PPS_PIN_PPS_OUT)
@@ -969,6 +968,8 @@ static int bnxt_ptp_pps_init(struct bnxt *bp)
 	ptp_info->n_per_out = 1;
 	ptp_info->pps = 1;
 	ptp_info->verify = bnxt_ptp_verify;
+	ptp_info->supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS;
+	ptp_info->supported_perout_flags = PTP_PEROUT_DUTY_CYCLE;
 
 	return 0;
 }
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v2] bnxt_en: support PPS in/out on all pins
  2025-10-19 22:57 [PATCH net-next v2] bnxt_en: support PPS in/out on all pins Vadim Fedorenko
@ 2025-10-20 11:08 ` Pavan Chebbi
  2025-10-22  1:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Pavan Chebbi @ 2025-10-20 11:08 UTC (permalink / raw)
  To: Vadim Fedorenko
  Cc: Michael Chan, Jakub Kicinski, Andrew Lunn, David S. Miller,
	Eric Dumazet, Paolo Abeni, Richard Cochran, netdev

[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]

On Mon, Oct 20, 2025 at 4:27 AM Vadim Fedorenko
<vadim.fedorenko@linux.dev> wrote:
>
> Add supported_extts_flags and supported_perout_flags configuration to make
> the driver complaint with the latest API.
>
> Initialize channel information to 0 to avoid confusing users, because HW
> doesn't actually care about channels.
>
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> index db81cf6d5289..1425a75de9a1 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> @@ -952,7 +952,6 @@ static int bnxt_ptp_pps_init(struct bnxt *bp)
>                 snprintf(ptp_info->pin_config[i].name,
>                          sizeof(ptp_info->pin_config[i].name), "bnxt_pps%d", i);
>                 ptp_info->pin_config[i].index = i;
> -               ptp_info->pin_config[i].chan = i;
>                 if (*pin_usg == BNXT_PPS_PIN_PPS_IN)
>                         ptp_info->pin_config[i].func = PTP_PF_EXTTS;
>                 else if (*pin_usg == BNXT_PPS_PIN_PPS_OUT)
> @@ -969,6 +968,8 @@ static int bnxt_ptp_pps_init(struct bnxt *bp)
>         ptp_info->n_per_out = 1;
>         ptp_info->pps = 1;
>         ptp_info->verify = bnxt_ptp_verify;
> +       ptp_info->supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS;
> +       ptp_info->supported_perout_flags = PTP_PEROUT_DUTY_CYCLE;
>
>         return 0;
>  }

Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>

> --
> 2.47.3
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5469 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v2] bnxt_en: support PPS in/out on all pins
  2025-10-19 22:57 [PATCH net-next v2] bnxt_en: support PPS in/out on all pins Vadim Fedorenko
  2025-10-20 11:08 ` Pavan Chebbi
@ 2025-10-22  1:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-22  1:50 UTC (permalink / raw)
  To: Vadim Fedorenko
  Cc: michael.chan, pavan.chebbi, kuba, andrew+netdev, davem, edumazet,
	pabeni, richardcochran, netdev

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 19 Oct 2025 22:57:20 +0000 you wrote:
> Add supported_extts_flags and supported_perout_flags configuration to make
> the driver complaint with the latest API.
> 
> Initialize channel information to 0 to avoid confusing users, because HW
> doesn't actually care about channels.
> 
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> 
> [...]

Here is the summary with links:
  - [net-next,v2] bnxt_en: support PPS in/out on all pins
    https://git.kernel.org/netdev/net-next/c/91f76771dba0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-22  1:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-19 22:57 [PATCH net-next v2] bnxt_en: support PPS in/out on all pins Vadim Fedorenko
2025-10-20 11:08 ` Pavan Chebbi
2025-10-22  1:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).