netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Mengyuan Lou <mengyuanlou@net-swift.com>
Subject: Re: [PATCH net-next 2/3] net: txgbe: support TX head write-back mode
Date: Mon, 20 Oct 2025 08:48:52 -0700	[thread overview]
Message-ID: <20251020084852.1a26a330@kernel.org> (raw)
In-Reply-To: <20251020082609.6724-3-jiawenwu@trustnetic.com>

On Mon, 20 Oct 2025 16:26:08 +0800 Jiawen Wu wrote:
> +	tx_ring->headwb_mem = dma_alloc_coherent(tx_ring->dev,
> +						 sizeof(u32),
> +						 &tx_ring->headwb_dma,
> +						 GFP_KERNEL);
> +	if (!tx_ring->headwb_mem) {
> +		dev_info(tx_ring->dev, "Allocate headwb memory failed, disable it\n");
> +		return;
> +	}
> +
> +	memset(tx_ring->headwb_mem, 0, sizeof(u32));

drivers/net/ethernet/wangxun/libwx/wx_lib.c:2932:23-41: WARNING: dma_alloc_coherent used in tx_ring -> headwb_mem already zeroes out memory, so memset is not needed
-- 
pw-bot: cr

  reply	other threads:[~2025-10-20 15:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20  8:26 [PATCH net-next 0/3] Implement more features for txgbe devices Jiawen Wu
2025-10-20  8:26 ` [PATCH net-next 1/3] net: txgbe: support RX desc merge mode Jiawen Wu
2025-10-20  8:26 ` [PATCH net-next 2/3] net: txgbe: support TX head write-back mode Jiawen Wu
2025-10-20 15:48   ` Jakub Kicinski [this message]
2025-10-20  8:26 ` [PATCH net-next 3/3] net: txgbe: support RSC offload Jiawen Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251020084852.1a26a330@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=mengyuanlou@net-swift.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).