From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA28335061 for ; Tue, 21 Oct 2025 13:12:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761052358; cv=none; b=i/0rBOoeSIOpS/n78DFVrSMdps+b4rhwC6dkVxuGJHEWlBAgjhLisrcF0XBpdBc3e80BpfTlf83HIZG5sUnEgyv2UCc2DgrmlXTBaa82SoHiUwMCYWRl4/Eet6FaWasSeRP5mkmJ8z9d4Rwemv47meRAVRrqycwSbSV4OFJ47YI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761052358; c=relaxed/simple; bh=7+jDJzQgtyEPYcVuSgV1uYiiukpFkSoFMl0hFJQNCTw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qtvCIlXuAG0jisOH1BIpJVJFXtorTxH7dlP+/ZmYgUouUrCOVJJ9hP0BLdCWklNOH8HlQHnRfJP0st+d3rvxAiL4d2xt0n3kyhykbzZZfFUjf5Q3lXgoeqOQqjDYDt3EFX9aMn+Gggx9NQgGbV7LIR1Qrl7cDWhotIWuIfOW1Kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W3StfoX5; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W3StfoX5" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2698d47e776so41449345ad.1 for ; Tue, 21 Oct 2025 06:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761052356; x=1761657156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IkFgnaC4/fY4vKIhcUTMhNPw5g98lm3qgHiWbbZwuIc=; b=W3StfoX5yLEM7B9wF5zRaYxC7WNiCUivQfOUmOzL0IdGjKxF9qdMnBY9rkgft1m0hl nTNA/UyoxuT/ndAr/R2oI6kGqAiocw6yMRFtQM80ghTlif7WqD0wc0T+6d6vAkOuXdDA 5g1X4QE2/6swWauC5VQBHi1BLQN1enBLVG20KG46n872bS+sIYbo0MfzcCoXHZ92YgUI SpkhRi1AWS4XM3lM1eAcSCd+ciZBK58gALD9prcV+js9ipGNfdZYEFEexNkzAQqGiKIR ZN0sjUQd4FF3FTqEJ82MkBylZFBTRqQHQOebHYvVdkNuVDLsa+9/+D1zdyZ85ni1CflX qkBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761052356; x=1761657156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IkFgnaC4/fY4vKIhcUTMhNPw5g98lm3qgHiWbbZwuIc=; b=U9RyBgppTOqBh8yxB+TQsmR2Os4LW7i2Ntta1FV/Bik1gr3lyoPiANgZSdNIdINrVa l+6G72kqT7giDZK8t+6bCCobr15O6uAwzMoZ6c5ZVlg+w8MGVFz4DvQaSokYkwNQxQeY 4qFd5MxcqJrIvHhTi9ElveQWGnpRReg25sUGjucXaafz5OJqMHhHDBio3qBLI2NZQwA1 crlfqWBaHHXFvG+MN9hoB1ECKjnU6Lk6yFVMhw2V1w3IvaOIcNW/19w7GmHl6kM8enw8 wJuUgrO1BHZltphWzwLYB8GYyjEa+5SE/XcCCXrEwCvV8If1n4O6XWiUSZkud6O0sERd 8F+w== X-Forwarded-Encrypted: i=1; AJvYcCWRz+a7zoem3LSr42xOK5WY6PIZmFg+Meixt2Xa7FoWbsmxpE3I+6FT+1MFA2aJ9x6hegW2uVw=@vger.kernel.org X-Gm-Message-State: AOJu0YxA+aiVGMVj3NZ04To1QzbmMKgR2v21ke59KcCYC0yTZgxDw2em 7xctVbe5sCtx0zrqb4BwyEak4mr/fSicZkhVIH+fYZvyTjJkN2+T0T7l X-Gm-Gg: ASbGncvBdQB4Yzx3P6AXHJEShRDutNqI3hM2Y09FfV9CkoOc4pHjcAEyV4fOWO7/LFJ /vnfCj8VtBVN6QRsPF/JKLKjmBDnkE44LKsYLwmjQjplxF4rQM8pyG/K9pPnS5vPKaaDTd6gkbG w/ndUGmmvZUW08Yp3pqK7ydkjiywu04v5V2ul1uKvirAGWTfWaf/Gr67hMEBZlrnTyLzbcLJvXx bmaqupjPkbGel+tgbV9grK6JeRTYMG0wVPgWT4WNJV1NUPfO1Sit+MmIKtL6/1mI6qqv+BQveq4 Y3iZOan7T4aLHdv0QhqBZIRRoIcv5MiDpRTmRfP+xuockwl9FGjG08YC64gOcYJ1x0p4ofV2pMn 1zxI4VrZtRWcryPee4y5KgZzSfQHEFP6Mt/QdtE5MlBzm0BW5K3eyueBgfzT/RgR7h2/BI8jWhU 3QDQA2Lrs46HxT76eHnyAsl8mWTlw9HyuNA3ey33dh65ZXj/XkhOsVZ2t0BA== X-Google-Smtp-Source: AGHT+IHSE+HSMwEtZuaexxTGBoXkowdxa0+CBkT84r7lRSRwSibKGFd5ahl3BirzVNaC5Sq8Q/eBMw== X-Received: by 2002:a17:902:cf42:b0:290:a3ba:1a8b with SMTP id d9443c01a7336-290c9cd4ae7mr197316205ad.24.1761052355150; Tue, 21 Oct 2025 06:12:35 -0700 (PDT) Received: from KERNELXING-MB0.tencent.com ([43.132.141.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-292471fd9ddsm109248175ad.89.2025.10.21.06.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 06:12:34 -0700 (PDT) From: Jason Xing To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, bjorn@kernel.org, magnus.karlsson@intel.com, maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com, sdf@fomichev.me, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, joe@dama.to, willemdebruijn.kernel@gmail.com Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, Jason Xing Subject: [PATCH net-next v3 4/9] xsk: add direct xmit in batch function Date: Tue, 21 Oct 2025 21:12:04 +0800 Message-Id: <20251021131209.41491-5-kerneljasonxing@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20251021131209.41491-1-kerneljasonxing@gmail.com> References: <20251021131209.41491-1-kerneljasonxing@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jason Xing Add batch xmit logic. Only grabbing the lock and disable bottom half once and sent all the aggregated packets in one loop. Via skb->list, the already built skbs can be handled one by one. Signed-off-by: Jason Xing --- include/net/xdp_sock.h | 1 + net/core/dev.c | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/include/net/xdp_sock.h b/include/net/xdp_sock.h index cb5aa8a314fe..5cdb8290f752 100644 --- a/include/net/xdp_sock.h +++ b/include/net/xdp_sock.h @@ -133,6 +133,7 @@ struct sk_buff *xsk_build_skb(struct xdp_sock *xs, struct sk_buff *allocated_skb, struct xdp_desc *desc); int xsk_alloc_batch_skb(struct xdp_sock *xs, u32 nb_pkts, u32 nb_descs, int *err); +int xsk_direct_xmit_batch(struct xdp_sock *xs, struct net_device *dev); #ifdef CONFIG_XDP_SOCKETS int xsk_generic_rcv(struct xdp_sock *xs, struct xdp_buff *xdp); diff --git a/net/core/dev.c b/net/core/dev.c index a64cef2c537e..32de76c79d29 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -163,6 +163,7 @@ #include #include #include +#include #include "dev.h" #include "devmem.h" @@ -4792,6 +4793,27 @@ int __dev_queue_xmit(struct sk_buff *skb, struct net_device *sb_dev) } EXPORT_SYMBOL(__dev_queue_xmit); +int xsk_direct_xmit_batch(struct xdp_sock *xs, struct net_device *dev) +{ + u16 queue_id = xs->queue_id; + struct netdev_queue *txq = netdev_get_tx_queue(dev, queue_id); + int ret = NETDEV_TX_BUSY; + struct sk_buff *skb; + + local_bh_disable(); + HARD_TX_LOCK(dev, txq, smp_processor_id()); + while ((skb = __skb_dequeue(&xs->batch.send_queue)) != NULL) { + skb_set_queue_mapping(skb, queue_id); + ret = netdev_start_xmit(skb, dev, txq, false); + if (ret != NETDEV_TX_OK) + break; + } + HARD_TX_UNLOCK(dev, txq); + local_bh_enable(); + + return ret; +} + int __dev_direct_xmit(struct sk_buff *skb, u16 queue_id) { struct net_device *dev = skb->dev; -- 2.41.3