From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD15329BDAA; Tue, 21 Oct 2025 23:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761088489; cv=none; b=HrEZutQ6sgF3Wg0mTGNqnGdlH7z/BlXh7F5OiMVOXPNutV/QiSHN5dPyS+rQGpFR6LqY73BZGga3secWHG1pMqfPBwLYv0l916+zOja1+dDM7QJynUNCYShmd6rkToMrT3ldanzPgGqkQsM8vFVxGGMCMRg4R+4bcnpy6Ep2mxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761088489; c=relaxed/simple; bh=7QQb4GTgchMrwGuaKApml7J8jP85IbcXmIf/phxMWxY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q5o1lCwn5tD7Oj7DNhXCuN+2aw2jKV/BkIM59PPOxQJ7OxAOChxMrYkLaHBwc7P2lDL5S8ZLiZG53Up6I7LkPip5W+ZSXGIA3t6VacGUhQ5CKWSHtzR+lue2TMHvNDzX5HKwso1y3hlIkUVrsNDtBhxZh8V1ngYQ1PLj7MZPbKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OnuUWCvJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OnuUWCvJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6070C4CEF1; Tue, 21 Oct 2025 23:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761088489; bh=7QQb4GTgchMrwGuaKApml7J8jP85IbcXmIf/phxMWxY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OnuUWCvJVLQsSu4pWgkWaxOa83IRzjCfhvxs5XaRWnA2ixzq06zRH6n6uGPKM10gw EV6uWJet0KcTtLQDUefCMwEiLnQgNVk6asZ6jUlrxdYnHaIYwUAmZ9EdMFD+bQKXW+ 8GpiuYEj4oBU+pIw6PvDGDAdlHlwTSGZ7lVOJQeeLKVp3Bbks/90pkarDWfDmKs3I1 Fe4dr2QXyEB1YZVWsIgDiehqROnVHNCKL2DzWWJPoTD1GA2C0PBFrV+TT6uU3B+lvA /2ZImK/7Kj0Et3cuVJbU2qMtPIcf+UyYwfAkfknZqzLD+c3IOhlm08NWkkr8gh7AY8 MVOXKudu7GfGw== Date: Tue, 21 Oct 2025 16:14:47 -0700 From: Jakub Kicinski To: Gerhard Engleder Cc: Horatiu Vultur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, richardcochran@gmail.com Subject: Re: [PATCH net-next] net: phy: micrel: Add support for non PTP SKUs for lan8814 Message-ID: <20251021161447.311a3e0f@kernel.org> In-Reply-To: References: <20251017074730.3057012-1-horatiu.vultur@microchip.com> <79f403f0-84ed-43fe-b093-d7ce122d41fd@engleder-embedded.com> <20251020063945.dwqgn5yphdwnt4vk@DEN-DL-M31836.microchip.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 20 Oct 2025 20:11:13 +0200 Gerhard Engleder wrote: > >> Hasn't net also switched to the common kernel multiline comment style > >> starting with an empty line? > > > > I am not sure because I can see some previous commits where people used > > the same comment style: > > e82c64be9b45 ("net: stmmac: avoid PHY speed change when configuring MTU") > > 100dfa74cad9 ("net: dev_queue_xmit() llist adoption") > > The special coding style for multi line comments for net and drivers/net > has been removed with > 82b8000c28 ("net: drop special comment style") > > But I checked a few mails on the list and also found the old style in > new patches. We removed the check that _suggests_ the use of the superior style. Aesthetic taste is not evenly distributed within the population. But we still prefer the old style in netdev. That said I don't think nit picking on comment style is productive, in either direction.