From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E27A017D2; Wed, 22 Oct 2025 00:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761091310; cv=none; b=JUROphAgUSjJaBu4JYcsoYpP8JiCR4ZoCJ6ty2eJ5mLp358cBbRFteHq4UWeyX+L7cRyCmscApymJJCxkiJovEPmhGsZQOkRUPFftG9siojrkIVa2OsmnP/zSDdc9laa0cGkzrLPKIs3IXCK2O5WBG2uZBCzmFwziR3cXQTqwnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761091310; c=relaxed/simple; bh=p+ZizTiGxIaoODfuSopyyeSnYFPc7WE7M0A6WnSxqmE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u4D6ewPeEo0w+gDdVDpwYtsOc19W8ec8CXh6Qogqr3WdIDSkCsF+94zy3L+JqQRRRj9K+BsSGwTTFcgrYwev+f8EsIHEAfN5BrnAPRavNgiRhfzCmqhLuuTCeoII75fNYNofDDmnUz9L9kU7Sdjofcbqr77XsVUay3Enuvrht4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pme7V+h4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pme7V+h4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49BA4C4CEF1; Wed, 22 Oct 2025 00:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761091309; bh=p+ZizTiGxIaoODfuSopyyeSnYFPc7WE7M0A6WnSxqmE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pme7V+h4OVfRJg7agdV9osvbp48/KAdTtFv4m7ugnYlgC5tWftPij+MItChJ57SjV 7+vRyzH+x4ac7qLh3UVJiDFqn7TAbluRfOWOgCOC4JToXzg8IXAiR5og2hUEI1/CEf kqkEmJ6uNAqhIn4DFo0iBEh0SajTNqk6ThpRxCjDt7IF9wWhMwmvahIi3Yzbd4VTcw GDV/Nd519/dZwYtNrpCBd+GJQ6vl5ZSST8D047hX/uOxLgDCXVM4Nz94I+Kez97U0K vNDOKNWZaJS+21bEFY0HZ57CeeUmRZHMKU4okd21jA65Z454Qy/qmSPHHHqKgxAI+x Z2JSVzIsvys4Q== Date: Tue, 21 Oct 2025 17:01:47 -0700 From: Jakub Kicinski To: Bobby Eshleman Cc: Stefano Garzarella , Shuah Khan , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?UTF-8?B?UMOpcmV6?= , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, berrange@redhat.com, Bobby Eshleman Subject: Re: [PATCH net-next v7 08/26] selftests/vsock: improve logging in vmtest.sh Message-ID: <20251021170147.7c0d96b2@kernel.org> In-Reply-To: <20251021-vsock-vmtest-v7-8-0661b7b6f081@meta.com> References: <20251021-vsock-vmtest-v7-0-0661b7b6f081@meta.com> <20251021-vsock-vmtest-v7-8-0661b7b6f081@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 21 Oct 2025 16:46:51 -0700 Bobby Eshleman wrote: > Improve usability of logging functions. Remove the test name prefix from > logging functions so that logging calls can be made deeper into the call > stack without passing down the test name or setting some global. Teach > log function to accept a LOG_PREFIX variable to avoid unnecessary > argument shifting. > > Remove log_setup() and instead use log_host(). The host/guest prefixes > are useful to show whether a failure happened on the guest or host side, > but "setup" doesn't really give additional useful information. Since all > log_setup() calls happen on the host, lets just use log_host() instead. And this cannot be posted separately / before the rest? I don't think this series has to be 26 patches long. I'm dropping this from PW, please try to obey the local customs :(